Repository navigation
Fix review findings: preview origins, inquiry form reset, CI format check - #29
Merged
Merged
Conversation
…rmatting in CI - Allow VERCEL_BRANCH_URL so the form and admin sign-in work on branch preview links - Give the inquiry dialog a fresh form after a request was sent - Run oxfmt --check in CI and format the two drifted files - Run CI on pull requests and pushes to main only, not twice per PR commit Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
isAllowedOriginnow also acceptsVERCEL_BRANCH_URL. Before, the inquiry form and/api/admin/sessionreturned 403 when a preview was opened through its branch alias. Covered by a newtests/origin.test.ts./api/requests.oxfmt --check.README.mdandtests/database.test.tswere reformatted (no content change in the test file).pushis limited tomain, so PR commits no longer run the workflow twice.Verification
Locally: lint, format check, typecheck, 34 unit and database tests, production build, and 6 public UI tests pass.
Not covered: the authenticated e2e specs, and the branch-alias fix on a real Vercel preview (unit-tested only).
🤖 Generated with Claude Code