Repository navigation
Fix layers disappearing after dismissing a view controller presented from them - #3610
Open
Andrei Salavei (ASalavei) wants to merge 1 commit into
Open
Andrei Salavei (ASalavei) wants to merge 1 commit into
Andrei Salavei (ASalavei) wants to merge 1 commit into
Conversation
Andrei Salavei (ASalavei)
requested review from
Vladimir Mazunin (mazunin-v-jb) and
Vendula Švastalová (svastven)
November 13, 2026 14:28
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…from them When a view controller is presented from LocalUIViewController inside a layer, UIKit moves the layers view out of the transition view and doesn't put it back on dismissal. Re-embed ComposeLayersView into the transition view from didMoveToSuperview while the layers are shown. Fixes CMP-10589
Andrei Salavei (ASalavei)
force-pushed
the
andrei.salavei/CMP-10589-layers-disappear-after-dismiss
branch
from
November 13, 2026 15:52
5e33cf1 to
efe1217
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a view controller is presented from LocalUIViewController inside a layer, UIKit moves the layers view out of the transition view and doesn't put it back on dismissal. Re-embed ComposeLayersView into the transition view from didMoveToSuperview while the layers are shown.
Fixes https://youtrack.jetbrains.com/issue/CMP-10589/Issue-when-presenting-another-view-controller-within-BottomSheet-using-LocalUIViewController.presentViewController
Release Notes
Fixes - iOS