Repository navigation
Fix Popup and Dialog platform width during rotation animation - #3541
Closed
Andrei Salavei (ASalavei) wants to merge 3 commits into
Closed
Andrei Salavei (ASalavei) wants to merge 3 commits into
Andrei Salavei (ASalavei) wants to merge 3 commits into
Conversation
Andrei Salavei (ASalavei)
marked this pull request as draft
October 27, 2026 17:08
Andrei Salavei (ASalavei)
marked this pull request as ready for review
November 12, 2026 12:37
Andrei Salavei (ASalavei)
marked this pull request as draft
November 12, 2026 12:38
Ivan Matkov (MatkovIvan)
left a comment
Ivan Matkov (MatkovIvan)
left a comment
There was a problem hiding this comment.
I do not think that it's a Popup/Dialog problem. All such user layouts inside the app will behave the same.
Also, expect/actual is a wrong mechanism (for the library) for customizing layout - it does not depend on compile target
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During screen rotation animation iOS may provide in-between values of the scene size, which will be converted to non-expected platform dialog.
Extract expect
rememberPreferredDialogLayoutWidthfunction that provides correct Popup and Dialog content constraints.Fixes https://youtrack.jetbrains.com/issue/CMP-10832/Popup-resizes-incorrectly-when-rotating-device
Release Notes
Fixes - iOS