feat: ALERT pre- and post-KF AI PID inference - #1368
Conversation
skuditha
commented
Jul 30, 2026
- Replaces the existing ALERT pre-PID implementation with the new AHDC- and ATOF-based TorchScript models.
- Adds post-KF PID inference for every valid ALERT::ai:projections pair.
- Writes predicted particle IDs and class probabilities to the existing ALERT AI PID banks.
…ed the feature extraction for the postpid model
There was a problem hiding this comment.
The old translator did logits.softmax(1) before toFloatArray(). Both new translators (ModelPrePID.java:290, ModelPostPID.java:84) read the raw output tensor. argmax is unaffected, so pid/prepid are fine either way, but if the exported TorchScript modules end in a Linear rather than a Softmax, then p2212/prob_2212/... are logits, and downstream users of a bank field literally named prob_* will be misled. Can you confirm the export includes the softmax?
|
Resolved Mathieu's comments. CI will fail until the pull request to merge the models to the networks repository is approved. (https://code.jlab.org/hallb/clas12/coatjava/networks/-/merge_requests/13) |
|
I merged https://code.jlab.org/hallb/clas12/coatjava/networks/-/merge_requests/13 and manually triggered @dependabot to create #1369. |
|
@skuditha Are you sure you addressed all? Looks like the bank names may still not exist. (Also, you can mark them "resolved" if they are so.) |