docs(rrm): correct render-resource-manager.md for the texture pipeline redesign - #752
Merged
Merged
Conversation
…e redesign The doc still described RRM's ImageHandle/GPUImage/ScheduleSwap(ImageHandle,...) system as if it existed. PR #751 deleted that system outright (zero real consumers) in favor of Rendering::Textures::TextureHandle everywhere. Update the status header, naming note, and the two most misleading checklist items to point at the real current API (IngestTexture, ScheduleTextureReload, ReleaseTexture, GetTexture, VulkanDevice::DestroyTexture) instead of the removed one. Sections 2-10's prose is left as-is and explicitly scoped as accurate for buffers/meshes only, consistent with this doc's existing correction-callout convention.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
render-resource-manager.mdstill described RRM'sImageHandle/GPUImage/ScheduleSwap(ImageHandle,...)system as if it existed. PR #751 deleted that system outright (zero real consumers — confirmedGetImage/Release(ImageHandle)were dead code) in favor ofRendering::Textures::TextureHandleeverywhere.This updates:
IngestTexture,ScheduleTextureReload,ReleaseTexture,GetTexture,VulkanDevice::DestroyTexture).GPUImage/GetImageclaim.§10checklist items, which explicitly checked offImageHandle/GetImage/GetImageMutableas shipped.Sections 2-10's prose is left as-is and explicitly scoped as accurate for buffers/meshes only, consistent with this doc's existing correction-callout convention (it was already carrying prior "shipped vs. proposed" corrections before this change).
Test plan