PR 5b: Browser chrome — Properties↔Cart rail, delete-409 dialog, Appears in N Views - #427
Draft
allison-truhlar wants to merge 9 commits into
Draft
PR 5b: Browser chrome — Properties↔Cart rail, delete-409 dialog, Appears in N Views#427allison-truhlar wants to merge 9 commits into
allison-truhlar wants to merge 9 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 5b — Browser chrome for Neuroglancer Views
Stacked on #426 (
ngviews-05a-cart-pipeline). Read-only scope. Adds the Browse-side chrome for the Views feature — no backend changes (the 409 delete guard and the/viewsendpoint already shipped in PR 2).Built via subagent-driven-development from
docs/superpowers/plans/2026-08-07-ngviews-05b-browser-chrome.md— 7 tasks, each with a spec+quality review gate, plus a whole-branch final review and one polish fix wave. Full frontend suite 360 passing;node-checkat the stack's known 5-error baseline (pre-existing, untouched files).Part 1 — Right-edge Properties↔Cart rail + cart drawer
useLayoutPrefsgains an ephemeralpropertiesDrawerMode: 'properties' | 'cart'+selectDrawerMode— reuses the existing"properties"panel id, solayoutConstants/layout-persistence keys are untouched (no new panel-combination keys).BrowseRightRail(Browse-only, always-visible right strip): Properties ⓘ + Cart 🛒 with a live count badge (useCartCount),aria-pressedon each.PropertiesDrawerrenders a cart body (<CartList/>+ "Open full Layer Cart" →/ngviews?tab=cart) when in cart mode, outside the file-selection gate.<CartList/>extracted fromNGViewsso the/ngviewstab and the drawer share one implementation;NGViewsreads?tab=cart.Part 2 — Data Link delete: dependent-Views confirmation
useDeleteProxiedPathMutationnow preserves the backend409 {detail:{message,dependent_views}}body via a manual status branch (notsendRequestAndThrowForNotOk, which drops it), throwing a typedDependentViewsError; adds aconfirm?payload →?confirm=true.handleDeleteDataLink(proxiedPath, confirm?)re-throws the typed error; the sharedDataLinkDialogdelete branch shows a confirm sub-view listing the caller's own dependent Views and re-issues the delete withconfirm=true. Fixed once in the shared path → covers both delete entry points (Properties drawer + Data Links table).Part 3 — Properties "Appears in N Views"
useViewsForDataLinkQueryhook (mirrorsfetchViews;GET /api/proxied-path/{sharing_key}/views, 404 →[]).AppearsInViewssection in the Properties Overview tab, shown only when the selected file has a Data Link.Deferred (tracked)
Stack
01→02→03→04(#425)→05a(#426)→**05b**→06(embedded-readonly).