Repository navigation
feat: add the File New Task dialog - #34
Merged
Merged
Conversation
Replace the system Run dialog with a Task Manager dialog that takes a command line and an optional administrative-privileges checkbox. The launch uses ShellExecuteEx off the UI thread, with runas for elevation, and reports failure immediately without claiming the task is still alive. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 531c252a3c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Resolve the whole New Task input as one shell resource before ShellExecuteExW, so unquoted paths such as C:\Program Files are not cut at the first space. Apply SHRestricted(REST_NORUN) to every New Task entry, including the Applications-page button and view popup. Co-authored-by: jameslincn <jameslincn@outlook.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File → New Task previously opened the system Run dialog (
IShellDispatch::FileRun). It now opens a Task Manager dialog with a command line and an optional “create this task with administrative privileges” checkbox.ShellExecuteExW. Administrative launches use therunasverb. There is no custom token path.Optionsis unchanged. New strings are inTextKeyand every locale.IDM_RUNkeeps its resource ID, routing, enabled state, and status-bar help.Checks
Local Linux cross typecheck (not a Windows device test):
cargo fmt --all -- --checkcargo check --all-targets --lockedforx86_64-pc-windows-msvc,i686-pc-windows-msvc, andaarch64-pc-windows-msvccargo clippy --all-targets --locked -- -D warningsfor those three targetsgit diff --checkcargo testandcargo build --releasedid not link here: this host has no Windows SDK import libraries (kernel32.liband the rest). CI on Windows is the test and release build.