Repository navigation
Run Users session actions on the background worker - #33
Merged
Merged
Conversation
Disconnect, log off, and send message still confirm on the UI thread, but the identity re-check and WTS calls now run on the users worker. A reused session is reported as a failure, and the three commands have status-bar help in every locale. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
TerminateProcess fails once a process has started exiting, and a zero timeout can miss the process object becoming signaled. Wait briefly after that failure so a descendant that exits on its own is not reported as a partial failure. Co-authored-by: jameslincn <jameslincn@outlook.sg>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disconnect, log off, and send message were already on the Users page. The identity re-check and the WTS calls still ran on the UI thread inside
UserPageState::handle_command. Those calls now go through the existing users worker.WTSDisconnectSession,WTSLogoffSession, orWTSSendMessageW, the worker re-queries the session and requires the sameUserSessionIdentity(session id, logon time > 0, user, domain). A mismatch isERROR_INVALID_PARAMETER.IDM_DISCONNECT(3212),IDM_LOGOFF(3215), andIDM_SENDMESSAGE(3210) is inTextKeyand every locale.Options, the process tree, and the open process-filter, startup, disk-history, and process-column work are untouched.Checks
Ran here, against the
x86_64-pc-windows-msvctypecheck target:cargo fmt --all -- --checkcargo check --all-targets --lockedcargo clippy --all-targets --locked -- -D warningsgit diff --checkcargo testandcargo builddid not link: this machine has nolink.exe. That typecheck is not a Windows device test. CI on Windows is the test run.