Repository navigation
Show a creation-checked process tree on the Processes page - #32
Merged
Merged
Conversation
Parent links come from the same system snapshot as the rows and stay attached only when that parent identity is older than the child. Expand, collapse, and the flat list are session commands and are not stored in Options. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Processes page can group each row under the parent from the same committed snapshot. A link is kept only when both sides are verified
ProcIdentityvalues and the parent was created at or before the child, so a reused PID does not adopt the wrong process. A missing parent stays a root. A row that is absent from the snapshot is dropped and the other rows remain.Options.src/pages/processes/tree.rs. The UI thread only lays out and paints the links the worker already resolved.Tests
cargo fmt --all -- --check,cargo check --all-targets --locked, andcargo clippy --all-targets --locked -- -D warningspassed for thex86_64-pc-windows-msvctarget on Linux. That is a cross typecheck, not a Windows device run.The process-tree unit tests also ran under Wine on a GNU cross build: parent resolution, reused PIDs, missing parents, cycles, expand/collapse, refresh, and flat-list mode (14 targeted tests, plus the rest of the process-page unit tests except the live Idle query and the process-spawning tree-termination test). Wine's system snapshot did not include PID 0, so the pre-existing live Idle query was not treated as a result for this change.