Repository navigation
feat: filter processes by image name - #27
JamesLinYJ wants to merge 1 commit into
Conversation
Add a classic Filter field on the Processes page. The filter is a UI-thread view of the committed snapshot, so sampling, tokens, and icons stay on the worker. Selection is kept by ProcIdentity across refresh, including when a row is hidden and the filter is later cleared. Co-authored-by: jameslincn <jameslincn@outlook.sg>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3956b5a39
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else { | ||
| self.pending_find_identity = Some(identity); | ||
| self.selected_identity = Some(identity); | ||
| self.refresh_processes(); |
There was a problem hiding this comment.
When Go to Process clears an active filter but the requested identity is absent from the currently committed snapshot, this branch only queues an asynchronous refresh. The edit box and name_filter are already empty, while visible_rows and the ListView still show the old filtered subset until that refresh completes; if collection fails, the blank filter can remain paired with the filtered list indefinitely instead of continuing to display the prior trustworthy snapshot. Rebuild the existing snapshot immediately after clearing the filter, before scheduling collection.
AGENTS.md reference: AGENTS.md:L40-L42
Useful? React with 👍 / 👎.
2 participants
Summary
Adds an image-name filter on the Processes page. The filter is a view over the snapshot that is already committed. It does not query processes, tokens, or icons, and it does not change the sampler.
Optionsstays#[repr(C)]schema 2; the filter text is not stored.ProcIdentityacross refresh. A row hidden by the filter stays in the identity cache while that process is still in the unfiltered snapshot, and it is selected again when the filter is cleared. Otherwise the highlight moves to a visible match. Go to Process clears the filter so the requested process can be shown.TextKeyand every locale.Tests
Verification
This host is Linux.
cargo fmt --all -- --checkpassed.cargo check --all-targets --lockedandcargo clippy --all-targets --locked -- -D warningspassed forx86_64-pc-windows-msvc. The same check passed fori686-pc-windows-msvcandaarch64-pc-windows-msvc.cargo test --locked --bin taskmgrstops becauselink.exeis not on this machine. These checks are not a Windows device test.CI on this PR runs Quality (x86_64) and Architecture (i686, aarch64), including the Windows test and release builds.