Repository navigation
feat(mobile): a sender's name above its message opens the sender's thread - #1022
Conversation
…read Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Pre-merge checks:
|
Jacksondr5
left a comment
There was a problem hiding this comment.
Combined review: reviewer-opus and reviewer-sol (Claude Opus 5.5 and GPT Sol 6.1), head 66fbe4a
Both of us reviewed the PR independently. Neither found anything that blocks merge.
- The link.
ParticipantAuthorLinewraps the sender's name in a link-rolePressableonly whenuseSenderThread().refis non-null. That's the same refJ5OpenSenderThreaduses: gated onuseQuietThreadShell, so a thread the reader can't see stays plain text. It reaches peers through the identity read's thread and a brief's spawner throughj5SenderThreadRef, and it opens throughuseOpenLinkedThread. - Layout. The
Pressabletakesshrinkand itsTextkeepsnumberOfLines={1}, so a long name still truncates before the tag or badge. Hooks stay unconditional. - Unchanged. People, other-person and notice lines are unchanged, matching web, as the Captain directed.
- Scope. One J5-owned file, with no seam, no FORK change and no docs change; AC1 already covers it.
No unit test is needed for a tap that uses the existing ref.
Code approval: the panel has no open code findings. Still pending: the tester's live checks (a local sender, a peer sender, and an unavailable thread staying plain), the captures, and green J5 CI.
|
A correction to the combined review: it said "AC1 already covers it", and that citation is wrong. The current AC1 is the five-groups rule. The decision to link the sender's name is in the definition's 2026-10-17 history entry (the old AC1), and the current text says mobile takes the same treatments. The code verdict is unchanged: no findings. |
Problem
At Checkpoint 4, Jackson tapped an agent's name in a Captain's timeline on his iPhone, such as "questioner" (a Crew member), and nothing happened. On web, the name above another agent's message opens that agent's thread. Part of #1011 (part 2).
What changed
Unchanged, matching web. Names in notice lines (silence, not delivered, Exchange dropped or withdrawn) stay plain text. Crew notices already open seats: the approval line's seat names and each seat line's "Open seat thread". Widening this to notice lines on both clients is for Jackson to decide later.
Part 1 of #1011 (the answered question's casing) is parked. The stored question and both rows are in sentence case, so it waits for Jackson's screenshot.
UI changes
Android. Before is trunk
a77b81158a; after is66fbe4a2a8.After tapping a name:
A Crew member's name opening the member's thread:
crew-name-opens-thread-66fb.mp4
A spawn brief's name opening the Captain's thread:
peer-brief-opens-captain-66fb.mp4
Live testing
Pass on Android at
66fbe4a2a8, by the wave 5 Android tester (Sol 6.1), with real Claude Haiku turns:Not exercised:
Checklist
apps/mobile/src/j5/a2a/timeline.tsxis J5-ownedBuilt by Claude Opus 5.5 in Claude Code, as builder-timeline in the mobile catch-up Crew.
🤖 Generated with Claude Code