Skip to content

Hmmer again - #41

Merged
AbhirupaGhosh merged 18 commits into
mainfrom
hmmer-again
Aug 10, 2026
Merged

Hmmer again#41
AbhirupaGhosh merged 18 commits into
mainfrom
hmmer-again

Conversation

@AbhirupaGhosh

@AbhirupaGhosh AbhirupaGhosh commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Description

What kind of change(s) are included?

  • Feature (adds or updates new capabilities)
  • Bug fix (fixes an issue).
  • Enhancement (adds functionality).
  • Breaking change (these changes would cause existing functionality to not work as expected).

Checklist

Please ensure that all boxes are checked before indicating that this pull request is ready for review.

  • I have read and followed the CONTRIBUTING.md guidelines.
  • I have searched for existing content to ensure this is not a duplicate.
  • I have performed a self-review of these additions (including spelling, grammar, and related).
  • I have added comments to my code to help provide understanding.
  • I have added a test which covers the code changes found within this PR.
  • I have deleted all non-relevant text in this pull request template.
  • Reviewer assignment: Tag a relevant team member to review and approve the changes.

@AbhirupaGhosh AbhirupaGhosh self-assigned this Jul 31, 2026
@AbhirupaGhosh
AbhirupaGhosh marked this pull request as ready for review August 5, 2026 00:00
@AbhirupaGhosh

Copy link
Copy Markdown
Contributor Author

If you have your favorite bug's duckdb (with protein_cluster_seq table), use that to try
.runHMMER() and .defenseHMMER()

@AbhirupaGhosh

Copy link
Copy Markdown
Contributor Author

@epbrenner and @jananiravi, currently, we are not using any cut-off for evalue. The default is E <= 10. I think 1e-3 or a stringency like 1e-5 cut-off would make more sense. Let me know your thoughts.
Otherwise, the PR is again ready for your review.

Added verbosity toggle for .runHMMER and .defenseHMMER, reducing console print hijinx. Replaced older vapply and lapply mapping with purrr map and map_lgl implementations. Added a flag that suggests (re)starting Docker if it's on the PATH but can't be reached, suggesting it may not be running.
@epbrenner

Copy link
Copy Markdown
Contributor

@AbhirupaGhosh Give it a spin with my minor updates to make sure it's running well still on your end, but all basic functionality looks good! All databases install and scan with the primary .runHMMER and .defenseHMMER functions.

@epbrenner epbrenner left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a secondary check by @AbhirupaGhosh of my verbosity and mapping changes in the most recent commit. :shipit:

@AbhirupaGhosh

Copy link
Copy Markdown
Contributor Author

I ran the whole thing again just to check things are in place. Next step is adding HMMer runs to runDataProcessing().

@AbhirupaGhosh
AbhirupaGhosh merged commit c87e065 into main Aug 10, 2026
@AbhirupaGhosh
AbhirupaGhosh deleted the hmmer-again branch August 10, 2026 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants