Skip to content

Update GHA skill and harden GHA - #17

Merged
johnalotoski merged 5 commits into
masterfrom
jl/gha-update
Nov 13, 2026
Merged

johnalotoski merged 5 commits into
masterfrom
jl/gha-update

Conversation

@johnalotoski

Copy link
Copy Markdown

Update GHA security guidance and workflows to clarify fork trust boundaries and narrow publishing permissions.

  • Run secret-free unit checks for fork PRs while retaining AWS-backed integration tests for same-repository PRs.
  • Require successful CI for the exact container release commit from a master push or manual run on master.
  • Restrict release write permissions and token exposure to publishing.
  • Disable Actions caching while preserving S3 snapshots and Nix binary caches.
  • Move shell expression inputs through environment variables and document CI behavior.

Fork job conditions route checks; GitHub’s fork token and secret restrictions provide the security boundary.

Validation: workflow lint and shell checks passed, excluding the installed Actionlint version’s unsupported cache-mode key.

Run secret-free unit checks for fork PRs while retaining AWS-backed
integration tests for same-repository PRs.

Require successful master CI for the exact container release commit,
narrow release permissions, disable Actions caching, and pass shell
inputs through environment variables. Document the CI trust model.
Restore only the newest two ledger snapshots and prune stale cache
data after verified clean shutdown. Preserve immutable chunks and
keep operations confined to the selected S3 prefix.

Add regression coverage for transfer failures, pruning safeguards,
progress reporting, and isolation from the Preview cache.
Make integration CI restore-only and serialize cache writes through
a dedicated Network Synchronization workflow.

Share bounded node-sync logic, expose query failures, and require
clean shutdown before saving. Preserve same-repository PR integration
tests and document cache maintenance and manual dispatch.

This comment was marked as resolved.

Wait for valid progress instead of exiting when a successful tip query
omits it. Bound retries by the synchronization deadline and preserve
zero-target behavior.

Add regression coverage for missing and invalid progress, recovery,
and timeout handling.
@johnalotoski
johnalotoski marked this pull request as ready for review November 13, 2026 01:30

@snarlysodboxer snarlysodboxer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnalotoski
johnalotoski merged commit 6d96291 into master Nov 13, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants