Repository navigation
Normalize rational protocol parameters before comparison - #3854
Merged
Merged
Conversation
Normalize decimal and numerator/denominator protocol parameter values to fractions before comparing them with proposed updates. Convert floats through their decimal strings to avoid binary rounding artifacts. This prevents false failures for equivalent values such as 8337/16000 and 0.5210625. Validation: make lint passed. E2E validation was not run because no Cardano node cluster was running.
Move rational parameter conversion into shared helpers and reuse it for governance thresholds, Leios quorum, Plutus prices and db-sync checks. Compare committee action thresholds numerically in both JSON forms. Separate unit prices from integer execution budgets with CostPerUnit, and document the purpose and fields of both data classes. Add framework regression tests and extend the committee action-view E2E check. Validation: 661 framework tests passed, with one expected failure. Linters passed. E2E validation was not run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8337/16000and0.5210625.get_rational_pparam()into shared utilities and reuse it for governance thresholds, Leios quorum, Plutus prices, and db-sync checks.CostPerUnit) from integer script execution budgets (ExecutionCost) and document both.Testing
make lint: passed.