Drop the inert timeseries securityCategories field - #107
Merged
Conversation
Mirrors the api's chore/remove-timeseries-security-categories. The field was stored, writable and returned, but nothing read it: no part in access control (dataset grants are Keycloak organization groups), no query filtering on it, and the backend silently dropped any id that did not already exist - which is why the four update tests covering it were xfail rather than assertions. Gone from TimeSeries and TimeSeriesUpdateFields, from the PyO3 constructor, getters and update form, from the stubs, and from the tests. ListFieldU64 goes with it: TimeSeriesUpdateFields.securityCategories was its only field on either side, so the Python wrapper class had nothing left to type. test_resource_label_updates' wrapper-invariant loop takes ListFieldIdCollection in its place rather than losing a case. Also corrects EventUpdate's docstring, which named ListFieldU64 for a list that has used ListFieldIdCollection for a while. Files keep their own securityCategories (INode) - separate entity, separate question. Safe to land ahead of the api: the api defaults the absent field, and nothing here sets deny_unknown_fields, so a response that still carries it still deserializes. It is the old SDK against the new api that 400s, so this wants to ship first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SFK7fDtg6QQrZdXsFBzGUv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the api's chore/remove-timeseries-security-categories. The field was stored, writable and returned, but nothing read it: no part in access control (dataset grants are Keycloak organization groups), no query filtering on it, and the backend silently dropped any id that did not already exist - which is why the four update tests covering it were xfail rather than assertions.
Gone from TimeSeries and TimeSeriesUpdateFields, from the PyO3 constructor, getters and update form, from the stubs, and from the tests. ListFieldU64 goes with it: TimeSeriesUpdateFields.securityCategories was its only field on either side, so the Python wrapper class had nothing left to type. test_resource_label_updates' wrapper-invariant loop takes ListFieldIdCollection in its place rather than losing a case. Also corrects EventUpdate's docstring, which named ListFieldU64 for a list that has used ListFieldIdCollection for a while.
Files keep their own securityCategories (INode) - separate entity, separate question.
Safe to land ahead of the api: the api defaults the absent field, and nothing here sets deny_unknown_fields, so a response that still carries it still deserializes. It is the old SDK against the new api that 400s, so this wants to ship first.
Claude-Session: https://claude.ai/code/session_01SFK7fDtg6QQrZdXsFBzGUv