test(mcp): drop the field-coverage audit, keep the tool sweep - #106
Merged
Conversation
`mcp_full_tool_surface` recorded every `(tool, field)` pair it sent and ended by diffing that against the live `tools/list` schema, failing on any advertised parameter the sweep never drove. That audit is gone. It enforced a goalpost that moves with the api rather than with the SDK: a field added server-side failed a test that had nothing to say about whether the new field works, and the count it pinned (125 fields across 37 tools) was the api's number, not ours. The sweep itself is untouched — all 37 tools are still driven once with every write read back, and the `sweep_*` helpers still tear their entities down through the MCP delete tools. Removed with the audit: `assert_every_field_was_exercised`, the `exercised` registry on `McpClient`, and `record` that filled it. Consequence worth knowing: nothing in the repo now notices a server-side parameter addition, as was already the case for REST. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcp_full_tool_surfacerecorded every(tool, field)pair it sent and ended by diffing that against the livetools/listschema, failing on any advertised parameter the sweep never drove. That audit is gone.It enforced a goalpost that moves with the api rather than with the SDK: a field added server-side failed a test that had nothing to say about whether the new field works, and the count it pinned (125 fields across 37 tools) was the api's number, not ours.
The sweep itself is untouched — all 37 tools are still driven once with every write read back, and the
sweep_*helpers still tear their entities down through the MCP delete tools. Removed with the audit:assert_every_field_was_exercised, theexercisedregistry onMcpClient, andrecordthat filled it.Consequence worth knowing: nothing in the repo now notices a server-side parameter addition, as was already the case for REST.