Skip to content

perf: hoist unsupported-dtype blacklist out of the scipy.fft interface hot path #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intel-python-devops wants to merge 2 commits into
base: master
Choose a base branch
from
Open

perf: hoist unsupported-dtype blacklist out of the scipy.fft interface hot path #405

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f80f552
perf: hoist unsupported-dtype blacklist out of the scipy.fft interface h
Nov 2, 2026
4704d52
perf: make the unsupported-dtype check a frozenset lookup
jharlow-intel Nov 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions mkl_fft/interfaces/_float_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@

import numpy as np

# dtypes the scipy.fft interface rejects; np.dtype keys make `in` a hash lookup
_UNSUPPORTED_DTYPES = frozenset(
np.dtype(getattr(np, name))
for name in ("half", "float128", "complex256")
if hasattr(np, name)
)


def _upcast_float16_array(x):
"""
Expand Down Expand Up @@ -78,11 +85,6 @@ def _supported_array_or_not_implemented(x):
or complex128 type or raise NotImplementedError
"""
_x = np.asarray(x)
black_list = [np.half]
if hasattr(np, "float128"):
black_list.append(np.float128)
if hasattr(np, "complex256"):
black_list.append(np.complex256)
if _x.dtype in black_list:
if _x.dtype in _UNSUPPORTED_DTYPES:
raise NotImplementedError
return _x
Loading