Repository navigation
v0.5.1: restore SimBrief generation, report cancelled turns - #37
Merged
Merged
Conversation
Pin playwright to 1.64.1: the 1.65.0 driver needs libatomic.so.1, absent from python:3.12-slim, so v0.5.0 failed every Generate before the click. turn_status now reports cancelled after cancel_trip instead of the withdrawn approval_required result. CI builds the container image and starts the Playwright driver inside it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incident
v0.5.0 (Worker
bcca9620) failed every SimBrief generation before the click. Container log at 2026-11-13 05:05:30 UTC:playwright/driver/node: error while loading shared libraries: libatomic.so.1: cannot open shared object file.Dependabot #33 bumped playwright from 1.64.1 to 1.65.0. Its driver needs
libatomic.so.1, andpython:3.12-slimdoesn't have it. Unit tests mock the browser, so CI never started the driver. Production was rolled back to v0.4.7 (Worker42d1aede).Fix
playwright==1.64.1, the version proven in production through v0.4.7.turn_statusreturnscancelledaftercancel_trip. It used to repeat the cachedapproval_requiredand its "call approve_dispatch" instruction, which the live v0.5.0 cancellation test caught. There is a regression test, and it fails without the fix.imagebuilds the Dockerfile and starts the Playwright driver inside it.Verification (local)
Exception: Connection closed while reading from the driver, the same error as production. It passes on this branch withplaywright driver ok.pytest: 478 passed, 3 skipped. Ruff check and format are clean.🤖 Generated with Claude Code