[collision] Remove API export for proximity classes - #116
Merged
Conversation
th-skam
added
pr: clean
pr: status to review
epernod
added
pr: status ready
epernod
reviewed
May 29, 2026
epernod
left a comment
epernod
left a comment
Contributor
There was a problem hiding this comment.
normally this should stay, what is the error you get?
Collaborator
Author
It's not finding the exported symbols. The files are header only so either way we include the implementation. |
epernod
added
the
pr: status to review
epernod
approved these changes
Aug 18, 2026
epernod
left a comment
epernod
left a comment
Contributor
There was a problem hiding this comment.
ok let's merge this old one asis, not need to create .cpp files
epernod
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They're header only and confused MSVC in the new work