Repository navigation
Support for docker image publishing to GHCR - #144
Merged
Merged
Conversation
d10sfan
marked this pull request as draft
October 6, 2026 02:07
d10sfan
marked this pull request as ready for review
October 6, 2026 02:35
EllimistArcade
added a commit
to EllimistArcade/Rasa.NET
that referenced
this pull request
Oct 7, 2026
…he in-game API Upstream InfiniteRasa#119 added a "REST and in-game APIs" section to docs/setup.md, and the guide already had a "REST API" section for the same listener. Both are kept. The second is brought up to what the first adds: - JwtSecret and JwtTokenLifetimeSeconds in the settings table. - The startup log's fourth state, "endpoint auth". - The /ingame endpoints take no key: Rest.Public, Rest.ApiKey and their entries' Public and ApiKey do nothing for them (ApiEndpoint .RequiresApiKey is false). AllowedIps applies. They are off without an entry (Sensitive), and are in the endpoint table with a link to the other section. - 401 is also the answer to a code or token that is no good. - "docker-compose maps" becomes "the compose files map": upstream InfiniteRasa#144 replaced docker-compose.yml with compose.yml and compose.dev.yml. docs/gm-commands.md: - .ingameapiauth is listed under Server-wide. - A dot command's arguments are split on runs of spaces, not on single ones (ProcessCommand now splits with RemoveEmptyEntries).
EllimistArcade
added a commit
to EllimistArcade/Rasa.NET
that referenced
this pull request
Oct 7, 2026
…iteRasa#119 and InfiniteRasa#142 Two tests that fail on upstream development since those merges: StatusApiTests.AListenerThatCannotOpenItsPortStaysOffAndTheHostCarriesOn lists the REST API's endpoints. InfiniteRasa#119 registers four more (ingame/items, ingame/items/categories, ingame/items/{id}, ingame/session/exchange); the expected list has them. HandshakeValidationTests.AuthLoginRejectsTrailingBytes asked LoginPacket.Read to refuse a payload with bytes left in it. InfiniteRasa#142 took that check out again, because every login has them: the auth cipher pads a frame to a multiple of 8 bytes and ends it with an 8-byte checksum, and the packet is handed a reader over all of it. The test is replaced by AuthLoginIsReadFromTheFrameTheCipherDelivers, which writes a login (37 bytes), puts it through AuthCryptManager.Encrypt (48) and Decrypt, and reads it behind the opcode with 11 bytes left over. It fails with "Auth login payload contains trailing bytes" when the check is put back. Not changed: PlatformCompatibilityTests .DockerServicesRunWhereRequiredConfigurationAndAssetsExist, which reads docker-compose.yml. InfiniteRasa#144 replaced that file and the image's layout, and the test fails until its layout model is rewritten for them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.