Repository navigation
Fix logging in not working - #142
Merged
Merged
Conversation
damuras
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LoginPacket change in https://github.com/InfiniteRasa/Rasa.NET/pull/137/changes#diff-ff7f02095db56d12b2353c102f6344ccf71fd091d95fdd82d492123a2f3af2a2 broke logging into the client.
Removing that line fixed it. This PR removes that line so logging in works again, but would be worth looking into what can be done for those tests that keeps the game working.