Skip to content

Fix logging in not working - #142

Merged
damuras merged 1 commit into
InfiniteRasa:developmentfrom
d10sfan:fix-login-issue
Oct 6, 2026
Merged

damuras merged 1 commit into
InfiniteRasa:developmentfrom
d10sfan:fix-login-issue

Conversation

@d10sfan

@d10sfan d10sfan commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The LoginPacket change in https://github.com/InfiniteRasa/Rasa.NET/pull/137/changes#diff-ff7f02095db56d12b2353c102f6344ccf71fd091d95fdd82d492123a2f3af2a2 broke logging into the client.

 [2026. 10. 05. 15:21:46.155] [Error] Error reading a Login packet from 192.168.1.154, disconnecting client: System.IO.InvalidDataException: Auth login payload contains trailing bytes.
auth-1  |        at Rasa.Extensions.BinaryReaderExtensions.EnsureFullyConsumed(BinaryReader reader, String what) in /app/src/Rasa.Utils/Extensions/BinaryReaderExtensions.cs:line 53
auth-1  |        at Rasa.Packets.Auth.Client.LoginPacket.Read(BinaryReader reader) in /app/src/Rasa.Auth/Packets/Auth/Client/LoginPacket.cs:line 47
auth-1  |        at Rasa.Auth.Client.OnReceive(BufferData data) in /app/src/Rasa.Auth/Auth/Client.cs:line 342
auth-1  | [2026. 10. 05. 15:21:46.155] [Network] *** Client disconnected! Ip: 192.168.1.154
auth-1  | [2026. 10. 05. 15:21:46.156] [Network] Dropping 192.168.1.154: receive failed to start: Cannot access a disposed object.

Removing that line fixed it. This PR removes that line so logging in works again, but would be worth looking into what can be done for those tests that keeps the game working.

@damuras
damuras merged commit 97d5c28 into InfiniteRasa:development Oct 6, 2026
7 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants