feat(cambricon): add fill provider - #961
Draft
baominghelly wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fillinsrc/native/cambricon/ops/fill/.int64anduint64, and skip unsupported Cambriconfloat64test cases.Motivation
InfiniOps did not have a native Cambricon provider for the canonical
filloperator. This prevented Cambricon builds that explicitly select implementation 0 from executing fill operations through InfiniOps.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
A targeted Cambricon operator build and test were run after rebasing onto the latest
master. The repository-wide smoke build and smoke test set were not run, so this PR remains Draft.Test Results on Supported Platforms
fillbuild passedtests/test_fill.py: 48 passed, 6 skipped; repository smoke/full suite not runFull `pytest` output (optional)
Benchmark / Performance Impact
N/A — no performance benchmark was run.
Notes for Reviewers
FillUnionhandles FP16, BF16, FP32, and integer types up to 32 bits using NRAM-sized chunks.FillRaw64Unionhandlesint64anduint64by copying the exact 8-byte value, avoiding unreliable typed 64-bit scalar handling in the MLU kernel path.mulprovider.float64is intentionally not registered and its six test cases are skipped. Unsigned 16/32/64-bit paths are compiled but are not exercised by the currenttorch_mlupytest input set.clang-format --dry-run --Werrorandgit diff --check origin/master...HEADpassed. The repository-wide smoke and full suites were not run.