feat(cambricon): add gelu provider - #959
Open
baominghelly wants to merge 1 commit into
Open
Conversation
baominghelly
marked this pull request as ready for review
September 1, 2026 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/native/cambricon/ops/gelu/.float16andfloat32, with a custom MLU kernel for tanh approximation andbfloat16.float64cases intests/test_gelu.pybecause CNNL GELU does not support that dtype.Motivation
InfiniOps did not have a native Cambricon implementation for the canonical
geluoperator. This provider enables GELU execution on Cambricon while retaining CNNL where it is reliable and using a custom fallback for the remaining supported paths.Type of Change
feat— new feature / new operator / new platformfix— bug fixperf— performance improvement (no behavioral change)refactor— code restructuring without behavior changetest— adding or fixing tests onlydocs— documentation onlybuild/ci— build system or CI configurationchore— tooling, formatting, or other non-code changes!in the Conventional Commits prefix or aBREAKING CHANGE:footer)Platforms Affected
WITH_CPU)WITH_NVIDIA)WITH_ILUVATAR)WITH_METAX)WITH_CAMBRICON)WITH_MOORE)WITH_ASCEND)WITH_TORCH)Smoke Test Result
Targeted Cambricon operator build and test were run after rebasing onto
origin/master. The repository-wide smoke suite was not run.Test Results on Supported Platforms
tests/test_gelu.py: 42 passed, 14 skipped; full suite not runFull `pytest` output (optional)
Benchmark / Performance Impact
N/A — no performance benchmark was run.
Notes for Reviewers
float16andfloat32uses CNNL.bfloat16use the customGeluUnionkernel. The custom path computes infloat32before converting back to the output dtype.float64is intentionally unsupported on Cambricon and is skipped in the MLU test cases.bfloat16paths. The full repository smoke/full suite and performance benchmarks were not run.