fix: plant orbit-hist fault under project root for v0.43.0 - #39
Merged
Conversation
EigenScript #1106 dropped cwd load_file/import resolution. The planted fault wrote tests/orbit_hist_dump.eigs into $TMP and ran it from there; `import orbit` then failed (no eigs.json walk from /tmp), and set -e exited the suite right after the first PASS with no FAIL line. Keep the plant under tests/ so project-root resolution still finds orbit. Explains dynamics CI red on the v0.43.0 pin bump (run 34064151409) and the matching Dependabot CI red.
Same #1106 class as orbit-hist: bifurcation (and bif_mem) plant() copies under $TMP without eigs.json, so `import logistic` / module loads fail before assertions run — suite red after the orbit-hist fix (dynamics#39). Copy eigs.json into every planted TMP tree (bifurcation, bif_mem, lint).
Contributor
Author
|
Follow-up: planted-fault TMP trees now get |
InauguralPhysicist
deleted the
fix/orbit-hist-plant-under-project-root
branch
September 9, 2026 07:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EIGS_REF→v0.43.0(run 34064151409): suite dies after the firsttest_orbit_hist.shPASS with no FAIL line.$TMP/.../nocap.eigs. EigenScript #1106 no longer resolvesimport orbitvia cwd; without aneigs.jsonwalk from/tmp, the fault run aborts andset -efails the job.tests/so project-root resolution still findsorbit.Test plan
EIGS_REF=v0.43.0