fix: failsoft_classify_check bash-3.2 portable (v0.43.0 macOS release build) - #1117
Merged
Conversation
The v0.43.0 release build failed on both macOS jobs in tools/failsoft_classify_check.sh, which shipped two tool-version assumptions macOS violates: - `declare -A tally` + `tally[$tag]` (bash 4+): macOS bash 3.2 makes `declare -A` a syntax error and parses the string key as arithmetic on an unbound name, which `set -u` kills. Replaced with plain per-tag counters + case dispatch. - `make --eval` in compiled_union (GNU Make 3.82+): macOS ships Make 3.81, where the flag is unknown and the output empty, so every builtin file read as an ORPHAN. Replaced with a temp makefile that `include`s the real one and carries the print rule (3.81-compatible). This was masked by the declare -A crash until it was fixed; the #988 [99p] child-exit ledger surfaces both. Semantics unchanged (files=13 sites=136; ANSWER=70 CHANNEL=36 LITERAL=3 EMPTY=6 STRICT=7 TODO=14; selftest 13/13). No other child .sh uses a bash-4/make-3.82 construct. Also stamps CLAUDE.md Latest-release to v0.43.0 now that the tag exists (doc_drift_check gates it against the latest tag). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kpzyjv1SaLaqBf45FSFDhB
InauguralPhysicist
force-pushed
the
fix-failsoft-bash32
branch
from
September 6, 2026 21:34
148a529 to
a81347f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.43.0 release build failed on both macOS jobs:
failsoft_classify_check.shuseddeclare -A(bash 4+) over a fixed 6-tag set; macOS bash 3.2 mis-parses it andset -ukills it. The #988 [99p] child-exit ledger surfaced the latent bug (regular CI macOS uses a newer bash). Replaced with plain per-tag counters + case dispatch, semantics unchanged (selftest 13/13). Also stamps CLAUDE.md Latest-release to v0.43.0 (the tag now exists). After merge: delete + re-dispatch the v0.43.0 tag so it points at the fix.🤖 Generated with Claude Code