Skip to content

P0-17: Make AGENTS.md true; drop node --test from Makefile and CI #195

Open

Description

@charliehuge

Part of #175 (audit Phase 0). Evidence: docs/audit/2026-11-09/detail/docs.md §2 AGENTS.md; detail/showcontrol-core.md §0.5–0.7.

Three sentences in the agent entry point are false, and they propagate to four other docs.

Claim Where Reality Fix
"make test runs Node tests (FundingCAPTCHA) + Python pytest" AGENTS.md:8, docs/agents/running-and-testing.md:6 No JS tests exist; the only one ever was deleted 2026-05-11. node --test reports # tests 0. The only .js in the repo is FlowerBeds/layout_tool/layout.js. Remove node --test from Makefile; remove the setup-node step from .github/workflows/tests.yml; fix both docs.
"IIVision.Blob3D.world_pos_cm() converts between them" AGENTS.md:13, docs/agents/python-conventions.md:20,28 Blob3D has no such method. The camera→world conversion is IIVision.transforms.orbbec_to_world() (transforms.py:62). world_pos_cm is a field on TrackedBlob. Name the real function.
"firmware reads a generated config.h" AGENTS.md:15, docs/agents/configuration.md:113, docs/agents/firmware.md:9, ADR-0007:212 Only Firmware/TreeHouse_Controllers/include/net_config.h is generated. Firmware/FlowerBeds_Follow_ServoController/*.ino:25-27 hardcodes MAC and 192.168.1.51; scripts/hooks/firmware_config_gen.py:20 is a TODO. Either land P1-04 first, or amend the constraint to say which firmware reads generated config and that FlowerBeds is pending.

Also while in AGENTS.md: docs/agents/domain.md link (file deleted by P0-04); the "Docs" list should point at the docs that survive Phase 0.

Done when. Every sentence in AGENTS.md can be verified with grep or ls; make test runs only pytest; CI has no Node step.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentImplementation task suitable for an AI agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions