Skip to content

P0-13: Delete core dead code (looking_glass/deploy, smoke_test.py, unused setters and configs) #191

Open

Description

@charliehuge

Part of #175 (audit Phase 0). Evidence: docs/audit/2026-11-09/detail/showcontrol-core.md §2 "Confirmed dead".

Item Location Why dead
looking_glass/deploy/looking_glass.service + install.sh ShowControl/TreeHouse/looking_glass/deploy/ (59 lines) Service is self-declared OBSOLETE by ADR-0018. The installer duplicates TreeHouse/deploy/install.sh but is the only one that runs usermod -aG _seat; copy that one line into the live installer before deleting (see P1-06).
scripts/hooks/smoke_test.py 23 lines No-op stub (_ = data.get(...), exits 0). Nothing wires it; .claude/ is gitignored. Remove its mention from docs/agents/architecture.md:23.
ControllerConfig ShowControl/FlowerBeds/flower_beds.py:128-135 Imported by main.py:39 but never instantiated; hardcodes 192.168.1.50:9000 (constraint #3 violation).
_get_loop() ShowControl/FlowerBeds/visualizer.py:377-382 Zero callers; also useless global _loop at :378,415.
calibration_state ShowControl/FlowerBeds/main.py:222-223,274 Always the literal "calibrated". docs/FlowerBeds.md:146 tells operators to check it; fix the doc.
Unused setters TreeHouse/displays/effect.py:51-62, video.py:57-61, led.py:49-53, base.py:58-62 (enable), coordinator.py:412-413 (Coordinator.get) Zero callers. (Several of these files go entirely in P0-14; do this item first or fold it in.)
aiofiles ShowControl/FlowerBeds/requirements.txt:6 Imported nowhere
numpy ShowControl/TreeHouse/requirements.txt Not imported in TreeHouse (ADR-0018 removed it from the renderer)
Unused imports (pyflakes) FlowerBeds/main.py:39-48, FlowerBeds/visualizer.py:18, TreeHouse/pico_driver.py:6, Dashboard/serve.py:14, test_layout_tool.py:5-6, test_branch_positions.py:2, IIVision/test_detect_foreground.py:5

Done when. ~110 LOC gone; pyflakes IIVision ShowControl/FlowerBeds ShowControl/TreeHouse ShowControl/Dashboard ShowControl/OSCFabric is clean; make test unchanged.

Metadata

Metadata

Assignees

No one assigned

    Labels

    ready-for-agentImplementation task suitable for an AI agent

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions