Close file pointer in finally clause

[erikogabrielsson]

Exceptions in DICOMfileClient retrieve_instance_rendered(), iter_instance_frames(), retrieve_instance_frames(), andretrieve_instance_frames_rendered() or if caller abandons iteration early on iter_instance_frames() leaves the image_file_pointer open. Change so that it is always closed in a finally block.

[sonarqubecloud]

Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[pieper]

this sounds like a good fix. Can you look at the automated suggestions?

[erikogabrielsson]

@pieper: Do you mean the suggestions from sonarqubecloud? They do not look to be related to the bug fix.

[pieper]

Okay, if the issues are unrelated then you don't need to resolve them.

I haven't worked on this code for a while so I'm hesitant to make changes. Is there anyone else who uses this package actively who would like to review?

[CPBridge]

@pieper I will take a look in the next couple of days

[CPBridge]

Looks good to me, thanks @erikogabrielsson !

[CPBridge]

I'm going to go ahead, merge this, and put out a patch release (0.61.1)

[CPBridge]

@pieper note that the automated suggestions are nothing to do with the changes introduced in this PR so it doesn't make sense to fix them here, in my opinion. I created #126 to address them