Skip to content

Remove deprecated tol parameter from match_geometry - #118

Merged
fedorov merged 1 commit into
masterfrom
bug/highdicom_match_geometry_tolerance
Nov 13, 2026
Merged

fedorov merged 1 commit into
masterfrom
bug/highdicom_match_geometry_tolerance

Conversation

@CPBridge

@CPBridge CPBridge commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

After finding that the default settings of highdicom's Volume.match_geometry() method were too tight and conflated multiple concepts (positional tolerance, angular tolerance), it was deprecated in highdicom 0.29.0 (ImagingDataCommons/highdicom#517), just released. If you use it now, you will get a warning telling you to update to the newer parameters

Now I am going around and removing references to it that I have left around the internet, this being one of them. The new default parameters work on the case in the notebook, so I simply remove references to it completely.

@CPBridge
CPBridge requested a review from fedorov November 13, 2026 13:45
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fedorov
fedorov merged commit 2cc302d into master Nov 13, 2026
1 check passed
@fedorov
fedorov deleted the bug/highdicom_match_geometry_tolerance branch November 13, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants