You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
add notebooks to explore related external data - #108
Went through the two GDC notebooks (TCGA and CDDP_EAGLE) - a few suggestions -
query_gdc_pathology_reports sets size to the batch size, but some cases have two reports so a batch can match more files than size and GDC just returns the first page. For tcga_brca this drops a handful of patients, with paging on pagination.total the coverage looks like basically every patient has a report.
The survey cell counts report files for the whole GDC project and divides by IDC patients, so the second reports push some collections over 100%. Counting distinct cases.submitter_id within the IDC patient list would give the actual coverage.
For T, N and stage you might not need the regex, GDC already has diagnoses.ajcc_pathologic_t / _n / _stage as structured fields for almost all the BRCA cases. Grade is the exception (empty for BRCA) so the PDFs are still where grade, margins and LVI come from. Could be worth mentioning so people try the structured fields first.
GDC and IDC release on different schedules, so printing the GDC data release (from /status) next to the IDC version would help keep the numbers reproducible.
Happy to open a PR against your branch with these if thats easier as well
@aaronkanzer this is super helpful! Yes, a PR against the branch would be very welcomed!
Sounds good! I will post something in the coming days, thanks again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.