Skip to content

add notebooks to explore related external data - #108

Draft
fedorov wants to merge 1 commit into
masterfrom
related-external-data
Draft

fedorov wants to merge 1 commit into
masterfrom
related-external-data

Conversation

@fedorov

@fedorov fedorov commented Jul 30, 2026

Copy link
Copy Markdown
Member

No description provided.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@aaronkanzer

aaronkanzer commented Nov 14, 2026 •

Copy link
Copy Markdown

Went through the two GDC notebooks (TCGA and CDDP_EAGLE) - a few suggestions -

  1. query_gdc_pathology_reports sets size to the batch size, but some cases have two reports so a batch can match more files than size and GDC just returns the first page. For tcga_brca this drops a handful of patients, with paging on pagination.total the coverage looks like basically every patient has a report.

  2. The survey cell counts report files for the whole GDC project and divides by IDC patients, so the second reports push some collections over 100%. Counting distinct cases.submitter_id within the IDC patient list would give the actual coverage.

  3. For T, N and stage you might not need the regex, GDC already has diagnoses.ajcc_pathologic_t / _n / _stage as structured fields for almost all the BRCA cases. Grade is the exception (empty for BRCA) so the PDFs are still where grade, margins and LVI come from. Could be worth mentioning so people try the structured fields first.

  4. GDC and IDC release on different schedules, so printing the GDC data release (from /status) next to the IDC version would help keep the numbers reproducible.

Happy to open a PR against your branch with these if thats easier as well

@fedorov

fedorov commented Nov 15, 2026

Copy link
Copy Markdown
Member Author

@aaronkanzer this is super helpful! Yes, a PR against the branch would be very welcomed!

@aaronkanzer

Copy link
Copy Markdown

@aaronkanzer this is super helpful! Yes, a PR against the branch would be very welcomed!

Sounds good! I will post something in the coming days, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants