Repository navigation
Conversation
The Dunlop cubic interpolation used epsilon / 3.7 * D, which multiplies by D. The relative roughness term is epsilon / (3.7 * D), as in the Swamee-Jain branch above. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
max_headloss_allowed is a percent of the head, not a length. us_to_si_conversion does not convert it, but si_to_us_conversion divided it by ft_to_m, so the value reported with US units was 3.28 times too large. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude found these, I can't comment on the accuracy at all, but they all sound plausible - mixed up units, wrong order of operations? Classic mistakes.