12714 enable locally fair flag - #12722
Open
ashmanda-cs wants to merge 5 commits into
Open
ashmanda-cs wants to merge 5 commits into
ashmanda-cs wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The JSF workflow appears to disable/suppress Locally FAIR frontend coverage via LOCALLY_FAIR_ENABLED: "false", which undermines validating the newly enabled feature in CI.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This PR updates GitHub Actions workflows to enable the Dataverse “Locally FAIR” feature flag when starting the Docker-based stack during CI, aligning the CI environment with Locally FAIR expectations.
Changes:
- Add
-Ddataverse.feature.allow-locally-fair-data=trueto the “Start Dataverse stack” Maven command in both workflows. - Add
LOCALLY_FAIR_ENABLEDenv var to the JSF/Playwright test step (currently set to"false").
File summaries
| File | Description |
|---|---|
| .github/workflows/dataverse_jsf_tests.yml | Enables Locally FAIR feature flag at stack start; adds an env var affecting Locally FAIR-related frontend tests. |
| .github/workflows/container_integration_tests.yml | Enables Locally FAIR feature flag at stack start for container integration tests. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| DV_FULL_NAME: "Dataverse Admin" | ||
| ROOT_DATAVERSE: "/dataverse/root" | ||
| SKIP_PREFLIGHT: "true" | ||
| LOCALLY_FAIR_ENABLED: "false" |
Contributor
Author
There was a problem hiding this comment.
This is intended behavior to prevent the tests from flaking up on known regressions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Enables Locally FAIR during the docker build step and suppresses the locally FAIR JSF frontend test
Which issue(s) this PR closes:
Special notes for your reviewer:
N/A
Suggestions on how to test this:
Both the Container Integration Tests and JSF Frontend Tests MUST pass.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
N/A
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A