Skip to content

Validate bulk responses and mask keys in row errors - #7

Merged
Sheharyar-Malik merged 2 commits into
mainfrom
fix/bulk-errors-and-cache
Nov 5, 2026
Merged

Sheharyar-Malik merged 2 commits into
mainfrom
fix/bulk-errors-and-cache

Conversation

@MudassarTariq

@MudassarTariq MudassarTariq commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Bulk lookups now check that there is one result object for each submitted IP before using or caching a response. An invalid cached response triggers a fresh request. If an individual error contains the request’s API key, the formula masks it before displaying or saving it. This also covers errors already in the cache. Successful rows, blank cells and formula arguments are unchanged.

The test workflow uses Git and the runner’s Node version manager for Node 22 and 24. It no longer uses the JavaScript checkout and setup actions or needs token permissions.

All 27 regression tests passed on both Node versions. In separate local HTTP tests, all 33 README formula examples ran and a 50,000-address lookup returned every row in order, including 10,000 individual errors. These checks used test data and simulated Google services.

@MudassarTariq
MudassarTariq marked this pull request as ready for review November 5, 2026 10:21
@Sheharyar-Malik
Sheharyar-Malik merged commit 45fa391 into main Nov 5, 2026
2 checks passed
@Sheharyar-Malik
Sheharyar-Malik deleted the fix/bulk-errors-and-cache branch November 5, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants