Skip to content

DataCollection: add invisible fields to the form for verification for ILIAS 12 #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iszmais merged 1 commit into from
Aug 21, 2026
Merged

DataCollection: add invisible fields to the form for verification for ILIAS 12 #11972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 32 additions & 28 deletions components/ILIAS/DataCollection/classes/Content/class.ilDclRecordEditGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ public function getRecordData(int $record_id = 0): array
* init Form
* @move move parts to RecordRepresentationGUI
*/
public function initForm(): void
public function initForm(bool $ui = true): void
{
$this->form = new ilDclPropertyFormGUI();
$prefix = ($this->ctrl->isAsynch()) ? 'dclajax' : 'dcl'; // Used by datacolleciton.js to select input elements
Expand All @@ -295,39 +295,43 @@ public function initForm(): void
$inline_css = '';
foreach ($allFields as $field) {
$field_setting = $field->getViewSetting($this->tableview_id);
if ($field_setting->isVisibleInForm(!$this->record_id)) {
$item = ilDclCache::getFieldRepresentation($field)->getInputField($this->form, $this->record_id);
if ($item === null) {
continue; // Fields calculating values at runtime, e.g. ilDclFormulaFieldModel do not have input
}
$item = ilDclCache::getFieldRepresentation($field)->getInputField($this->form, $this->record_id);
if ($item === null) {
continue; // Fields calculating values at runtime, e.g. ilDclFormulaFieldModel do not have input
}

if (!ilObjDataCollectionAccess::hasWriteAccess($this->parent_obj->getRefId()) && $field_setting->isLocked(!$this->record_id)) {
$item->setDisabled(true);
}
if (!ilObjDataCollectionAccess::hasWriteAccess($this->parent_obj->getRefId()) && $field_setting->isLocked(!$this->record_id)) {
$item->setDisabled(true);
}

$item->setRequired($field_setting->isRequired(!$this->record_id));
$default_value = null;
$item->setRequired($field_setting->isRequired(!$this->record_id));
$default_value = null;

// If creation mode
if (!$this->record_id) {
$default_value = ilDclTableViewBaseDefaultValue::findSingle(
$field_setting->getFieldObject()->getDatatypeId(),
$field_setting->getId()
);
// If creation mode
if (!$this->record_id) {
$default_value = ilDclTableViewBaseDefaultValue::findSingle(
$field_setting->getFieldObject()->getDatatypeId(),
$field_setting->getId()
);

if ($default_value !== null) {
if ($item instanceof ilDclCheckboxInputGUI) {
$item->setChecked((bool) $default_value->getValue());
} else {
$item->setValue((string) $default_value->getValue());
}
if ($default_value !== null) {
if ($item instanceof ilDclCheckboxInputGUI) {
$item->setChecked((bool) $default_value->getValue());
} else {
if ($item instanceof ilDclTextInputGUI) {
$item->setValue("");
}
$item->setValue((string) $default_value->getValue());
}
} else {
if ($item instanceof ilDclTextInputGUI) {
$item->setValue("");
}
}
}
if (!$ui || $field_setting->isVisibleInForm(!$this->record_id)) {
$this->form->addItem($item);
} else {
$hidden = new ilHiddenInputGUI($item->getPostVar());
$hidden->setValue((string) $item->getValue());
$this->form->addItem($hidden);
}
}

Expand Down Expand Up @@ -487,7 +491,7 @@ public function save(): void
global $DIC;
$ilAppEventHandler = $DIC['ilAppEventHandler'];

$this->initForm();
$this->initForm(false);
$this->setFormValues();

// if save confirmation is enabled: Temporary file-uploads need to be handled
Expand Down Expand Up @@ -677,7 +681,7 @@ public function save(): void
if ($this->ctrl->isAsynch()) {
// If ajax request, return the form in edit mode again
$this->record_id = $record_obj->getId();
$this->initForm();
$this->initForm(false);
$this->setFormValues();
echo ilUtil::getSystemMessageHTML(
$this->lng->txt('msg_obj_modified'),
Expand Down
Loading