Skip to content

[FIX] UICore: encode cmd- and base-class parameters #11967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thibsy wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −4
Open

[FIX] UICore: encode cmd- and base-class parameters #11967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/ILIAS/UICore/classes/class.ilCtrl.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,7 @@ private function getTargetUrl(
$target_url = $this->appendParameterString(
$target_url,
self::PARAM_BASE_CLASS,
urlencode($base_class), // encode in case of namespaced classes
rawurlencode($base_class), // encode in case of namespaced classes
$is_escaped
);

Expand All @@ -889,7 +889,7 @@ private function getTargetUrl(
$target_url = $this->appendParameterString(
$target_url,
self::PARAM_CMD_CLASS,
urlencode($cmd_class), // encode in case of namespaced classes
rawurlencode($cmd_class), // encode in case of namespaced classes
$is_escaped
);
}
Expand Down
4 changes: 2 additions & 2 deletions components/ILIAS/UICore/classes/class.ilCtrlContext.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,14 +305,14 @@ protected function adoptRequestParameters(): void
// previously set existing path.
$base_class = $this->getQueryParam(ilCtrlInterface::PARAM_BASE_CLASS);
if (null !== $base_class) {
$this->setBaseClass($base_class);
$this->setBaseClass(rawurldecode($base_class));
}

// set or append the provided command class, which might
// override the previously set path again.
$cmd_class = $this->getQueryParam(ilCtrlInterface::PARAM_CMD_CLASS);
if (null !== $cmd_class) {
$this->setCmdClass($cmd_class);
$this->setCmdClass(rawurldecode($cmd_class));
}
}

Expand Down
Loading