Skip to content

harden: fix use-after-free in odbc_cursor.cpp (CWE-416) #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

harden: fix use-after-free in odbc_cursor.cpp (CWE-416) #495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/odbc_cursor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,9 +84,13 @@ class FetchAsyncWorker : public ODBCAsyncWorker {

public:
FetchAsyncWorker(ODBCCursor* cursor, Napi::Function& callback)
: ODBCAsyncWorker(callback), cursor(cursor), data(cursor->data) {}
: ODBCAsyncWorker(callback), cursor(cursor), data(cursor->data) {
// Keep the JS-side cursor object alive (preventing GC from running its
// destructor, which frees data->hstmt) while this worker is in flight.
this->cursor->Ref();
}

~FetchAsyncWorker() {}
~FetchAsyncWorker() { this->cursor->Unref(); }

void Execute() {
SQLRETURN return_code;
Expand Down Expand Up @@ -155,9 +159,13 @@ class CursorCloseAsyncWorker : public ODBCAsyncWorker {

public:
CursorCloseAsyncWorker(ODBCCursor* cursor, Napi::Function& callback)
: ODBCAsyncWorker(callback), odbcCursor(cursor), data(cursor->data) {}
: ODBCAsyncWorker(callback), odbcCursor(cursor), data(cursor->data) {
// Keep the JS-side cursor object alive (preventing GC from running its
// destructor, which frees data->hstmt) while this worker is in flight.
this->odbcCursor->Ref();
}

~CursorCloseAsyncWorker() {}
~CursorCloseAsyncWorker() { this->odbcCursor->Unref(); }

void Execute() {

Expand Down
Loading