Repository navigation
Give the dashboard cards a class of their own - #949
Merged
Merged
Conversation
The dashboards (1.25) styled their tiles as .hc-tile, the class of the console's icon boxes: every icon of the left menu and of Home's cards got the tiles' border and padding and sat at the bottom right of an empty frame. The cards are now .hc-dcard (dashboards, scripts, VM groups, diagnosis).
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on the production node (screenshot of Home): every icon of the left menu and of Home's cards sat at the bottom right of an empty frame since 1.25. Cause: the dashboards' tiles reused
.hc-tile, the class of the icon boxes. Renamed to.hc-dcard; a scan of the CSS added since 1.24 finds no other collision. Checked in headless Chromium (dark, crimson, menu pinned: Home and the script library).