Repository navigation
Rebuild the VM console - #946
Merged
Merged
Conversation
One toolbar on one row (modes as tabs, the state with the guest's resolution, icon tools with tooltips, a More menu for SPICE, the workstation panel, reconnect and disconnect), the stage sized to the room left below it and the picture scaled to fit (no fixed 16:10 box), states drawn on the stage, the keyboard capture shown, a clipboard panel (type into the VM, the guest's clipboard), display scale (fit, original size, ask the guest to follow the window), screenshot, and the remote desktop as a mode of the console. The console window and /rdp/<vm> use the same component. Design: docs/design/vm-console.md.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/design/vm-console.md.
Before: nine equal buttons wrapping over two rows, the screen in a fixed 16:10 box (empty bands beside a 4:3 guest), state/errors/warnings spread around it, remote desktop in a separate window, no Start for a stopped VM, no sign of keyboard capture.
After: one toolbar row (modes as tabs, state with resolution, icon tools, More menu), stage sized to the room left, picture scaled and centred, states drawn on the stage (stopped + Start, connecting, lost + reason + Reconnect, SSH admin-only, RDP sign-in), keyboard capture shown, clipboard panel, display scale menu, screenshot, remote desktop inside. Console window and /rdp/ share the component.
Tried in headless Chromium against a running VM of the production node (read-only stand-in API relaying its real VNC console): 1920×1080, 1600×900, 1366×768, the window, each mode's state, keyboard typing into the VM, original size, screenshot download; no page error. npm lint/build, vitest 125.