Repository navigation
Fix the schema update on a busy database and VM addresses for diagnosis and remote desktop - #938
Merged
Merged
Conversation
…osis and remote desktop - init_db tries the schema update again (up to six times) when SQLite answers 'database is locked': replacing the replication triggers needs the database alone, and the API's own writes made hyperlite-scheduler fail at its start after the update to 1.27.0 (systemd restarted it). - guest_agent.address_now: the agent's answer waited for, else the DHCP lease. The API's read-only libvirt cannot ask the agent, so the diagnosis had no address and made no live try; the remote desktop could miss the address on a first call.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while checking 1.27.0 on the production node:
sqlite3.OperationalError: database is lockedininstall_triggers), restarted by systemd. init_db now retries.read only access prevents virDomainQemuAgentCommand), so no live try. Newguest_agent.address_nowfalls back to the DHCP lease; also used byrdp.open.Tests: tests/test_console_27.py (12 passed) and the database tests. Remote desktop itself verified for real on antho against xrdp in a disposable VM (session opened, screen read through the relay).