Repository navigation
ui: open feedback in a global dialog and keep the page - #886
Merged
Merged
Conversation
HugoXK-bot
approved these changes
Nov 16, 2026
HugoXK-bot
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: PASS at 56275b6
Written-by: HugoXK-bot
Ran:
npx tsx --test test/feedback.test.ts test/repoTabs.test.ts— passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2303/2305 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2
Not run:
- A browser visual check; the rendered markup is covered by the tests.
- GitHub Actions (the PR runs CI).
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written-by: HugoXK
No-issue: owner-requested UI cleanup; feedback is a global action, not a Settings section.
What changed:
<dialog id="feedback-dialog">rendered by the layout, using the existing[data-open-dialog]pattern; without JavaScript it still goes to/settings#feedback./settings, where the inline form remains the no-JavaScript fallback and the feedback history stays./feedbackposts through a validatedreturnTo, so a note written from/dashboardreturns to/dashboardwith the flash notice instead of jumping to Settings.Expires{infoTip(...)}literal is fixed (${infoTip(...)}), and the settings test now rejects raw{infoTip(.Docs-not-needed: the endpoint, form fields and Settings fallback are unchanged; this moves the surface into the existing dialog pattern.
Ran:
npx tsx --test test/feedback.test.ts test/repoTabs.test.ts— passnpm run lint— pass (11 baselined warnings)npm run typecheck— passnpm run build— passnpm test— 2303/2305 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts,test/nginxCheck.test.ts) that also fail on a cleanorigin/mainnode scripts/risk-gate.mjs --base origin/main—risk-tier: T2node scripts/version.mjs check— oknpm run secret:scan— cleannode scripts/changelog.mjs check— 9 fragments okNot run:
Risk: T2 (
src/views/,src/app.ts); a PASS at the tip is required.