Skip to content

ui: open feedback in a global dialog and keep the page - #886

Merged
HugoXK merged 1 commit into
mainfrom
feat/feedback-dialog
Nov 16, 2026
Merged

HugoXK merged 1 commit into
mainfrom
feat/feedback-dialog

Conversation

@HugoXK

@HugoXK HugoXK commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Written-by: HugoXK

No-issue: owner-requested UI cleanup; feedback is a global action, not a Settings section.

What changed:

  • The footer's Feedback link now opens one <dialog id="feedback-dialog"> rendered by the layout, using the existing [data-open-dialog] pattern; without JavaScript it still goes to /settings#feedback.
  • The dialog is rendered only for approved viewers and not on /settings, where the inline form remains the no-JavaScript fallback and the feedback history stays.
  • The About card no longer duplicates the feedback button; it keeps the star link.
  • /feedback posts through a validated returnTo, so a note written from /dashboard returns to /dashboard with the flash notice instead of jumping to Settings.
  • The Expires{infoTip(...)} literal is fixed (${infoTip(...)}), and the settings test now rejects raw {infoTip(.
  • Tests: the dialog appears on a normal page, returns there after posting, the About duplicate is gone, and the settings page has no raw helper source.

Docs-not-needed: the endpoint, form fields and Settings fallback are unchanged; this moves the surface into the existing dialog pattern.

Ran:

  • npx tsx --test test/feedback.test.ts test/repoTabs.test.ts — pass
  • npm run lint — pass (11 baselined warnings)
  • npm run typecheck — pass
  • npm run build — pass
  • npm test — 2303/2305 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts, test/nginxCheck.test.ts) that also fail on a clean origin/main
  • node scripts/risk-gate.mjs --base origin/main — risk-tier: T2
  • node scripts/version.mjs check — ok
  • npm run secret:scan — clean
  • node scripts/changelog.mjs check — 9 fragments ok

Not run:

  • A browser visual check; the rendered markup is covered by the tests.
  • GitHub Actions (the PR runs CI).

Risk: T2 (src/views/, src/app.ts); a PASS at the tip is required.

@HugoXK-bot HugoXK-bot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: PASS at 56275b6
Written-by: HugoXK-bot

Ran:

  • npx tsx --test test/feedback.test.ts test/repoTabs.test.ts — pass
  • npm run lint — pass (11 baselined warnings)
  • npm run typecheck — pass
  • npm run build — pass
  • npm test — 2303/2305 pass; the two failures are pre-existing environment failures (test/gateBaseTree.test.ts, test/nginxCheck.test.ts) that also fail on a clean origin/main
  • node scripts/risk-gate.mjs --base origin/main — risk-tier: T2

Not run:

  • A browser visual check; the rendered markup is covered by the tests.
  • GitHub Actions (the PR runs CI).

@HugoXK
HugoXK merged commit 1be1045 into main Nov 16, 2026
33 of 34 checks passed
@HugoXK
HugoXK deleted the feat/feedback-dialog branch November 16, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants