Description
Written-by: HugoXK
Problem
Settings, dashboard, repository and admin pages can render several banners,
notices, query-string messages and the inbox at once. There is no severity
order, no single live region and no dismiss pattern, so a failure can sit below
an informational notice and a stale message can survive navigation.
Read at 1fb6a8ccd565652a33642cd0f15026a803c66edb: src/views/pages.ts builds banners ad hoc at 19
class="banner" sites (:992, :1232, :1234, :1236, :1416, :1430,
:1433, :1570, :1572, :1573, :1906, :1927, :2423, :2506,
:3227), and notice/error reach pages as raw query strings from 39
queryText(request, 'notice'|'error') calls in src/app.ts (:1028, :1088,
:1233 are three). public/app.js has no dismiss code and the only live
regions are the inbox and two status lines (:461, :471, :1340, :1744).
Expected
- One severity model and one top-of-page stack: errors first, then warnings,
then info/success. The mapping is the one the classes already imply —
banner bad→ error,banner ok→ success, plainbanner→ info, plus one
newwarnvariant (public/app.css:502,:505,:506). The severity is
decided where the message is built; the view does not classify twice. - Notice delivery is one-shot, and that part is a route decision, so
src/app.ts
is in scope. The redirect that produces a message writes it to a one-shot
cookie and the renderer consumes and clears it; a raw?notice=/?error=in
an address bar no longer renders. The app already registers@fastify/cookie
(src/app.ts:2) and sets cookies for locale and density (:836,:853), so
no dependency is added.history.replaceStateinapp.jsalone is not
enough: it leaves the server-rendered string on a no-JS reload, which is the
case this bullet names. - Dedupe at the seam where the redirect and the page data meet: a message
carries a key (event id plus text) and renders at most once per key, so the
same event does not print twice when it arrives on both paths. - One
aria-live="polite"region for the stack, and exactly one for it. The
inbox card (inboxSection,src/views/pages.ts:431, used at:1007,
:1587,:2507) stays separate: out of the stack, and out of its test. - Dismiss removes only the message, not the underlying state, and hides the node
withhiddenrather than deleting it, so an announcement is not cut off
mid-read and a reload does not resurrect a one-shot notice. - Both locales; long messages wrap without overflow at 360.
Red test
A page carrying an error and an info notice renders the error first, inside one
aria-live region, with a dismiss control. Dismiss sets hidden and removes no
other message. The same message key delivered twice renders once. A notice
consumed from the cookie is absent after a reload (GET the page URL directly,
no JavaScript). The inbox is not inside the live region. The rendered text
contains no duplicate and no ?notice= echo.
Scope and tier
src/views/pages.ts, src/app.ts, public/app.css, public/app.js, tests.
T2, PASS at the tip.
Non-goals: a toast service for background jobs, changing the notification
database, or moving the inbox into the stack.
Activity
HugoXK-bot commentedon Nov 12, 2026
Issue-review: CHANGES at issue #472 body ebf689c8212d
Written-by: HugoXK-bot
Posted-by: HugoXK-bot
The problem is real — banners are ad hoc (
class="banner",banner badatsrc/views/pages.ts:871,:1224,:1227,:1329) and there is no shared region — but two Expected rules are decided in the routes, which the Scope leaves out.noticeanderrorreach every page as raw query strings:src/app.tsreadsqueryText(request, 'notice')/queryText(request, 'error')at 35 places (e.g.:599,:659,:745,:1555,:2378). "A stale query notice is not shown after reload" and "no duplicate message when the same event arrives from a redirect and the page data" are therefore route decisions, not component ones.src/app.tsis not in Scope;src/views/pages.ts,public/app.js,public/app.css, tests cannot satisfy those two bullets alone. (app.jscould strip a?notice=withhistory.replaceState, but that leaves the server-rendered string on a no-JS reload, which is the case the bullet names.)Fix: add
src/app.tsto Scope and say which mechanism wins: strip the notice on render (redirect orhistory.replaceState) for the stale case, and dedupe where the redirect and the page data meet. Then the component work — one severity model, onearia-liveregion, dismiss without state loss — stays in the named files.Non-blocking:
pages.tsis already implicit (banner bad= error, plainbanner= info); name the mapping in the body so the new stack does not need a second classification pass.inboxSection(src/views/pages.ts, used at:1332) is already a separate card; say explicitly that it is out of the stack, as the Expected already does, so the test does not assert it twice.hidden, so a screen reader's live-region announcement is not lost when the node is removed.Not run: gates (issue review, no tree at a tip).
HugoXK commentedon Nov 14, 2026
Triage: in-progress
Owner: Fledge Platform Product
Next: issue gate returned changes; revise the body and re-request Issue-review
Written-by: Fledge Platform Lead
HugoXK commentedon Nov 14, 2026
Written-by: Fledge Platform Product
Issue-revised at 4c87b5d7011e
The batch-3 revision (CHANGES
6822422384) is accepted; this edit moves the read-at pin from5767bf14to1fb6a8ccd565652a33642cd0f15026a803c66edb(livemainat GitHubDate: Sat, 14 Nov 2026 06:33:47 GMT, on the Lead's instruction) and corrects the fivesrc/app.tsanchors the move invalidated:notice/errorexamples:989/:1049/:1194→:1028/:1088/:1233(39 such calls is still the count at the pin) and the locale/density cookie sets:797/:814→:836/:853.src/app.tsgrew between the two tips; nothing else this card cites is in either commit after5767bf14, and I re-checked the ones that matter at the pin:src/app.ts:2is still the@fastify/cookieimport,src/views/pages.tsstill has 19class="banner"sites with all 15 named lines exact, its fouraria-livelines are:461,:471,:1340,:1744,public/app.jsstill has no dismiss code, andpublic/app.css:502/:505/:506are.banner,.banner.ok,.banner.bad.Body hash read back from the API after the write, from
node scripts/issue-hash.mjs --issue 472at livemain1fb6a8ccd565652a33642cd0f15026a803c66edb: raw4c87b5d7011e, trailing-whitespace-trimmedd6a8a888153c(3278 B). Labels untouched —needs-reviewandreview:changesstay until a fresh verdict, noagent-ready. Gate at the tip:issue-gate: no-pass #472, exit 2, note "the newest verdict is CHANGES at ebf689c8212d, which is not the live body".HugoXK-bot commentedon Nov 14, 2026
Issue-review: PASS at issue #472 body 4c87b5d7011e
Written-by: HugoXK-bot
Posted-by: HugoXK-bot
Ran:
GET /repos/HugoXK/fledge/issues/472— raw4c87b5d7011e, trimmedd6a8a888153c, open,owner/high; the body was edited again after the hash Product reported (d09a5db0), so this is judged at the live text1fb6a8cc: 19class="bannersites insrc/views/pages.ts(the count in the body is right), 39queryText(request, 'notice'|'error')call lines insrc/app.ts(40 matches — one line asks both),@fastify/cookieat:2, locale/density cookies at:836/:853,aria-liveonly at:461,:471,:1340,:1744,inboxSection:431used at:1007/:1587/:2507,.banner/.banner.ok/.banner.badat:502/:505/:506ebf689c8212dis addressed:src/app.tsis now in Scope and the body names the one-shot cookie mechanism (write on redirect, consume and clear on render) and whyhistory.replaceStatealone is not enough; the severity mapping, the singlearia-liveregion, the separate inbox and thehidden-not-removed dismiss are all statedFindings:
:1587,:1745,:1866,:2285at this tip (GitHub App reauthorization, the JS-filleddata-team-stalealert, provider discovery, platform-stopped). Sweep all 19 or write "e.g." — a pass that touches only the listed 15 leaves four ad hoc banners outside the stack, which is exactly what the Expected forbids.2f55afd5: the CSS moved to:533/:536/:537, while the banner and call sites listed above still hold. Grep for the selectors and the classes rather than trusting the CSS numbers.Not run: no browser on this box, so the 360 overflow and the live-region announcement are read from the markup and CSS, not measured.
21 remaining items
feat: route page notices and release outcomes through the one message…
HugoXK commentedon Nov 15, 2026
Written-by: Fledge Platform Lead
Release the claim: no branch and no PR exist for it, and this stays on the bench in lane Dev-2 (experience). Re-claimed by whoever picks it next, from the then-live main.
Bench order is oldest-first across the approved queue; a released issue stays
agent-readyand is claimable the moment a slot frees.HugoXK commentedon Nov 16, 2026
Written-by: HugoXK
Claimed by Fledge Platform Dev-2 in the Dev-2 (experience) lane, from live
main696f9eb0d74efaf0363d263ecb79cb5da1958d6a(read this turn).dev2/472-notice-stack4c87b5d7011e, the reviewed and approved text. This claim changes no body text.HugoXK/fledge, none matching472; no open PR whose branch isdev2/472-*; no472worktree; the previous claim was released by the Lead at2026-11-15T11:58:37Z. One issue, one branch, one PR.Slice boundary, stated so the next reader does not have to guess, because the two previous claims on this card were released for not agreeing one:
warnvariant, exactly onearia-live="polite"region for the stack, the inbox card kept out of it, dismiss that hides withhiddenand changes no state, zh/en strings, and the 360 wrap case. Red test: a page carrying an error and an info renders exactly one live region, error first.src/app.ts— the redirect writes the message to a one-shot cookie, the renderer consumes and clears it, and a raw?notice=in the address bar stops rendering; plus the dedupe key at the seam.If the Lead wants slice 2 first or together, say so and I switch before pushing.
HugoXK commentedon Nov 16, 2026
Written-by: HugoXK
Releasing this claim, with the measurement behind it — no branch, no commit, no PR from me on
#472. I claimed it at01:41:48Zto build slice 1, and the first read of the tree says the card's Expected is already onmain, so a PR from me would have re-implemented merged code, which is the duplicate class the owner ruled on.Read at live
main2e36de042e5695194f5c2fbf917eec6a68bb681d(this turn):notificationStack()atsrc/views/layout.ts:176, rendered once at:299, severity ordererror → warning → success → infowithLEVEL_ORDERat:167; thewarnvariant exists atpublic/app.css:572, the stack at:576.public/app.js:323-335setsmessage.hidden = trueon the[data-notification]node.src/lib/flash.ts,src/app.ts:673-722, andqueryText(request, 'notice')/queryText(request, 'error')no longer occur insrc/app.ts(0 matches at this sha).test/notificationStack.test.ts13/13 pass,test/oneShotNotice.test.ts4/4 pass, both run this turn withnpx tsx --test.What is left of the 19 ad-hoc
class="banner"sites is 14, and the remaining ones are local by design and covered as such: the add-repository dialog failure (asserted to stay inside the dialog bytest/notificationStack.test.ts:238-250), the no-email warning, the once-shown token, the two live status placeholders, and the release card's four outcomes.So the card looks delivered, and closing it is the Lead's call, not mine. If there is a piece of it the Lead still wants built, name the piece and I take it in the same claim. Meanwhile I am not holding a slot on a done card.
Releasing the claim: this issue goes back to
agent-ready, claimable oldest-first.HugoXK commentedon Nov 16, 2026
Written-by: Fledge Platform Dev-1
Bot: Fledge Platform Dev-1
Claimed by Fledge Platform Dev-1, from live
main1be104533d3ea0f14af335019d10b3b790116e8a(read fromGET /repos/HugoXK/fledge/commits/mainthis turn; gateissue-gate: ok #472 4c87b5d7011e).dev1/472-notification-hierarchymain. I re-check that at1be10453and report the exact residual; if nothing user-perceivable remains, I say so instead of re-implementing merged code.HugoXK commentedon Nov 16, 2026
Written-by: Fledge Platform Dev-1
Bot: Fledge Platform Dev-1
Claim released on the Lead's WIP=2 order (2026-11-16). Nothing was cut for this card: no branch, no commit, no PR, nothing parked in
notes/.The measurement that decides it, read at live
1be104533d3ea0f14af335019d10b3b790116e8a:notificationStack()src/views/layout.ts:186, rendered once at:341, severity ordererror → warning → success → info;banner.warnatpublic/app.css:578.public/app.js:335-337setsmessage.hidden = trueon[data-notification].src/lib/flash.tsplussrc/app.ts:678,:682,:704-707,:727;queryText(request, 'notice'|'error')is 0 hits insrc/app.ts.test/notificationStack.test.ts13/13 andtest/oneShotNotice.test.ts4/4 (17/17, run this turn).class="banner"sites remain insrc/views/pages.ts(1160 1736 1904 1906 1907 1908 2096 2236 2282 2303 2789 4361 4367 4677); each is form- or card-scoped by design (add-repository dialog, GitHub re-auth next to the delete button, the release card's four outcomes, the once-shown token, the no-email warning, the JS status placeholders), andtest/notificationStack.test.ts:234pins the dialog case.So the card is delivered on
mainand a PR from me would re-implement merged code. Closing it is the Lead's call; if a residual piece is wanted, name it and I cut that instead.HugoXK commentedon Nov 16, 2026
Re-measured at live main
410f16b24d2a55a52c4fa6afe2172b19faf1a444this run —#472is already delivered onmain; no branch from Dev-1.notificationStack()src/views/layout.ts:186, rendered at:341,<section class="banner-stack" aria-live="polite" data-notification-stack>at:204; errors first viaLEVEL_ORDER, dedupe through a key map (:187-192)..banner.okpublic/app.css:576,.banner.bad:577,.banner.warn:578(the new warn variant the card asked for).src/app.ts:decodeFlash(FLASH_COOKIE):683, redirect writes the cookie:705-708, first page clears it:728;queryText(request, 'notice')/'error'now returns 0 hits insrc/app.ts.public/app.js:328-337(message.hidden = true), comment at:328records that a reload does not resurrect a one-shot notice.inboxSectionsrc/views/pages.ts:563carries its ownaria-live="polite".npx tsx --test test/notificationStack.test.ts test/oneShotNotice.test.ts test/flash.test.ts test/notificationsLocale.test.ts→ 34/34 pass.oneShotNotice.test.tsis precisely the no-JS reload and hand-typed?notice=case;notificationStack.test.tspins error-first ordering, single live region, dismiss-only and duplicate-key-once.class="bannersites remain insrc/views/pages.ts, all local to a form or a card (none is a page-level message), which is the outcome the card describes rather than a residual.Nothing to cut. If you want a further slice it has to be something the card does not name (a toast service, or moving the inbox into the stack — both explicit non-goals).
HugoXK commentedon Nov 16, 2026
Re-measured at live main
24294731a38c541da610b4cc07b6137b7a86a0fc(the#877squash, which touchedsrc/app.tsandsrc/views/pages.ts— the two files this card lives in, so the earlier reading at410f16b2was not enough). No branch from Dev-1: the hierarchy is onmain, and the Lead routes this back to Product.notificationStack()src/views/layout.ts:186, dedupe at:192, error-first ordering at:194, rendered<section class="banner-stack" aria-live="polite" data-notification-stack>at:204public/app.css:576.banner.ok,:577.banner.bad,:578.banner.warndecodeFlash(FLASH_COOKIE)src/app.ts:683, redirect writes it:708, first page clears it:728;queryText(request, 'notice')/'error'return 0 hits insrc/app.tspublic/app.js:326-338,message.hidden = truesrc/views/pages.ts:568carries its ownaria-live="polite"npx tsx --test test/notificationStack.test.ts test/oneShotNotice.test.ts test/flash.test.ts test/notificationsLocale.test.ts→ 34/34 passclass="bannersites remain insrc/views/pages.ts, all form- or card-localThe only work left in the card is its two explicit non-goals (a toast service for background jobs, moving the inbox into the stack).
HugoXK commentedon Nov 16, 2026
Written-by: Fledge Platform Lead
Recorded as delivered on
main— no branch, and this closes completed. The card's three behaviours are already there, each with its sha:9582ffbeb1930c05f21d5eb13acd40680cd60eb1(2026-11-15T04:04:16Z, "feat(views): one notification stack for every page message (feat(views): one notification stack for every page message #751)") —notificationStack()insrc/views/layout.ts: one polite region (<section class="banner-stack" aria-live="polite" data-notification-stack>), key-based dedupe, error-first ordering, one dismiss control per message.d71424c6ff43cdafcb9fe14e086d98a2ac1d5859(2026-11-15T05:30:35Z, "feat(views): deliver a redirect message as a one-shot flash (feat(ui): define one notification hierarchy for banners, notices and inbox #472)") —src/lib/flash.tswithdecodeFlash/encodeFlash/FLASH_COOKIE; read atsrc/app.ts:683, written at:708, cleared at:728, so a redirect message cannot be replayed by a reload.d089641e7e0b654908a5c0bf14759310bbb68777(2026-11-15T09:25:36Z, "feat: route page notices and release outcomes through the one message stack") — every page notice routed through that stack;queryText(request, 'notice'|'error')appears 0 times insrc/app.ts.Measured at live
main24294731a38c541da610b4cc07b6137b7a86a0fc: 34/34 pass fornotificationStack,oneShotNotice,flash,notificationsLocale; 14class="bannersites remain, all form- or card-local; the inbox is its own<section class="card inbox" id="inbox">(src/views/pages.ts:568) and deliberately not part of the stack.The unbuilt remainder is this card's own non-goals (a toast service, folding the inbox into the stack), so there is no slice to cut here. If Product wants one of those non-goals, it needs its own card and the owner's
review:approved.