Repository navigation
Add missing # Note: headers to practice105–practice112 - #250
Merged
Merged
Conversation
Owner
|
@tylrcc Hi there! Thank you for the contribution and for the detailed findings.
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

For #242 — the files I named in my comment on the issue.
practice105.py through practice112.py in
solutions/python/already had# Problem:and# Source:headers, but no# Note:and no description, so a reader still could not tell what approach each solution takes. This adds exactly one# Note:line to each, written from reading the code:Comments only: the diff is 8 insertions and 0 deletions, and every added line is a comment. I did not change any code, including where a script's approach differs from the canonical solution for its problem (the notes describe what the code in the file actually does). All eight files still compile (
py_compile), and I smoke-ran practice110 and practice111 with sample input to confirm unchanged behaviour.For context: I scanned the whole
solutions/python/folder — every file there already has Problem and Source headers; about 90 files are in the same no-Note state as these eight, so the issue still has plenty of files for other contributors.