fix: bump EDILibrary.Core 2.10.1 -> 3.3.1 (drops bogus FV2704) - #170
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps EDILibrary.Core 2.10.1 -> 3.3.1 (major).
Why: every EDILibrary release v2.9.0 through v3.3.0 (including 2.10.1 and 2.10.2) contains a non-existent
EdifactFormatVersion.FV2704; v3.3.1 removes it.Compatibility: the 3.0.0 release only drops netstandard2.1 and moves net9 -> net10; EDILibrary.Core 3.3.1 targets net8.0 and net10.0, so this repo (net8/net9/net10) still restores (net9 uses the net8 asset). The repo uses EDILibrary only for the
EdifactFormatVersionenum (members FV2310 used; no FV2704 reference anywhere). Release notes 3.0.0 to 3.3.1 list no API changes beyond that. No dotnet SDK was available locally, so CI is the gate. Note that this is a major dependency bump for consumers of this package.Checked against main at 6ee0c08.
🤖 Generated with Claude Code