Skip to content

Roll out reliable AI review evidence in OAuth - #210

Merged
heskew merged 2 commits into
mainfrom
ci/rollout-ai-review-4b59dc
Aug 21, 2026
Merged

Roll out reliable AI review evidence in OAuth#210
heskew merged 2 commits into
mainfrom
ci/rollout-ai-review-4b59dc

Conversation

@heskew

@heskew heskew commented Aug 21, 2026

Copy link
Copy Markdown
Member

Roll out the reliable review-evidence plumbing from HarperFast/ai-review-prompts#86 in OAuth by moving the Claude, Gemini, and caller-validator workflows to its verified merge commit. This keeps the review and validation paths on one immutable workflow, prompt, and script version.

For the human reviewer

No open judgment calls. The three caller pins move together to avoid validating the new review callers against a different upstream revision. Mention, issue-to-PR, permissions, triggers, secrets, model selection, layers, and OAuth-specific checks are unchanged.

Verification

  • git diff --check passed.
  • The caller-validator workflow passed against all three changed caller files.
  • GitHub reports 4b59dc0ddb15aff517884127b58204f79193b4f2 as the signed, verified merge commit for Make AI review calibration evidence reliable ai-review-prompts#86.
  • End-to-end route (c), live smoke: Harper #2256 loaded the same review pin; Gemini completed its context snapshot and exact run-marker posting with no blockers, while Claude correctly declined the caller-workflow change and Add MCP OAuth flow support #86 kept that failed attempt out of the verdict log.
  • Gemini reviewed the final d58736f… head and reported no blockers; all ordinary CI passed.

Review coverage

Authored by Codex, with the validator alignment follow-up authored by Claude Fable 5 from Kris Zyp's canary feedback. Independent Claude review covered the initial pin bump; Gemini reviewed the final head with no findings. Cursor and further domain adjudication were pruned by the minimal low-risk policy. Receipt @ d58736f.

Human-Review-Need: 2 @ d58736f

@gemini-code-assist

This comment has been minimized.

@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Reviewed; no blockers found.

kriszyp's review on harper#2256: the validator was left on 224c2ad while
the claude/gemini callers moved to 4b59dc0 — the #86 delta changes the
workflow contract the validator checks callers against, so the pins move
together.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01T4VjVDt6egBUxmGiASuahs
@heskew
heskew marked this pull request as ready for review August 21, 2026 19:44
@heskew
heskew requested a review from a team as a code owner August 21, 2026 19:44
@heskew
heskew removed the request for review from a team August 21, 2026 20:12
@heskew
heskew merged commit c6a18cb into main Aug 21, 2026
11 of 12 checks passed
@heskew
heskew deleted the ci/rollout-ai-review-4b59dc branch August 21, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant