Repository navigation
feat(sidebar): close a workspace terminal from its sidebar card - #87
Merged
Merged
Conversation
Hovering (or keyboard-focusing) a terminal card in the workspace's Terminals tab swaps its status glyph for a cross that closes the pane, through the same closePane path as the pane header's close button, so an unsaved editor still prompts first. Screens, connections and pending rows are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Review Summary
The implementation correctly adds a close button to workspace terminal cards in the sidebar, following the same two-sibling-button pattern as Shared Ports rows. The PR is well-structured with no merge-blocking defects found.
What was reviewed:
SessionRowrefactoring inmain.tsx: The component correctly branches ononClosepresence, rendering a<div className="closable-row">with two sibling buttons when closable. Thestateglyph is rendered as a sibling flex item that gets hidden on hover/focus-within via CSS.- CSS additions in
styles.css:.closable-row,.row-open,.row-closefollow the same pattern as.forward-row/.forward-open/.forward-close. Light-theme corrections for.row-closeand.row-close:hoverare properly included. - The call site (line 4231) passes
onClose={() => void closePane(session)}only forworkspaceSessions, consistent with the PR scope. - The
closePaneasync path (unsaved-editor guard, voice cancel, listing cleanup) is reused unchanged — the sidebar close goes through the exact same code as the pane header ×.
Passes: npm run typecheck, npm run build, npm run test per PR description. No issues blocking merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
closePanepath as the pane header's ×, so an editor with unsaved text still asks first.Verification
npm run typecheck✅,npm run build✅,npm test✅ (134 files, 2406 passed)🤖 Generated with Claude Code