Skip to content

fix(deps): clear the high-severity audit advisories - #85

Merged
SPhillips1337 merged 1 commit into
mainfrom
fix/npm-audit-2026-11
Nov 9, 2026
Merged

SPhillips1337 merged 1 commit into
mainfrom
fix/npm-audit-2026-11

Conversation

@SPhillips1337

Copy link
Copy Markdown
Contributor

Summary

npm audit fix limited to the version ranges already in package.json, lockfile only. Every bump is a patch or minor release:

  • vite 7.3.6 → 7.3.8, zod 4.6.2 → 4.6.7, undici 7.30.0 → 7.30.2 (and node-gyp's copy 6.29.0 → 6.29.1)
  • electron 43.7.9 → 43.8.7
  • electron-builder and its packages 26.17 → 26.18.1
  • hono, body-parser, qs, follow-redirects, semver and a few other small updates

This clears every high finding, so the Verify job's npm audit --audit-level=high step passes again. That step has failed on main since 2 November.

Still open: one moderate advisory

Six moderate findings remain, all from one minimatch advisory (GHSA-g3hv-75wg-m249) that only affects the packaging tools:

  • Where it comes from: app-builder-lib and @electron/universal, both part of electron-builder.
  • Why it isn't fixed here: the fix only exists in minimatch 11.0.1+. Even the latest electron-builder (26.18.0 on npm) still requires minimatch ^10.2.5, and npm audit fix --force would downgrade electron-builder to 25.1.0.
  • Impact: the release workflow audits at moderate, so it will still fail until this is handled. The options are an overrides entry forcing minimatch 11 onto the packaging toolchain, verified with a real package:win / package:linux build, or waiting for electron-builder to update.

Testing

  • npm audit --audit-level=high passes against the new lockfile.
  • The lockfile was updated with --package-lock-only because a running Electron instance had the local node_modules locked. This PR's CI run is the first clean install and full typecheck, test and build against it.

🤖 Generated with Claude Code

npm audit fix within existing semver ranges, lockfile only: vite 7.3.8, zod
4.6.7, undici 7.30.2 / 6.29.1, electron 43.8.7, electron-builder 26.18.1 and
smaller patch releases. `npm audit --audit-level=high`, which is what CI runs,
now passes.

Six moderate findings remain, all from one minimatch advisory
(GHSA-g3hv-75wg-m249, fixed only in 11.0.1+) reached through electron-builder,
whose latest release still requires minimatch ^10. Clearing them needs an
override that forces minimatch 11 onto the packaging toolchain, which is left
out until it can be checked against a real installer build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR performs a package-lock.json-only lockfile refresh via npm audit fix --package-lock-only, bumping several packages within their already-declared package.json version ranges to clear high-severity advisories.

Assessment: The changes are straightforward and accurate. All version bumps are minor or patch releases (vite 7.3.6→7.3.8, zod 4.6.2→4.6.7, undici 7.30.0→7.30.2, electron 43.7.9→43.8.7, electron-builder and related packages 26.17→26.18.1, hono, follow-redirects, qs, semver, and others). No logic errors, incorrect resolutions, or new security issues were introduced.

Known limitation (acknowledged in PR description): Six moderate findings remain from a single minimatch advisory (GHSA-g3hv-75wg-m249) in the app-builder-lib/@electron/universal packaging toolchain. The fix requires minimatch >=11.0.1, but electron-builder 26.18.1 still pins minimatch ^10.2.5 — meaning npm audit fix --force would downgrade electron-builder. This is an upstream constraint that cannot be resolved in this PR without breaking the build toolchain.

No blocking issues found. The PR achieves its stated goal of clearing all high-severity findings.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@SPhillips1337
SPhillips1337 merged commit bf1e3d8 into main Nov 9, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant