Repository navigation
fix(deps): clear the high-severity audit advisories - #85
Conversation
npm audit fix within existing semver ranges, lockfile only: vite 7.3.8, zod 4.6.7, undici 7.30.2 / 6.29.1, electron 43.8.7, electron-builder 26.18.1 and smaller patch releases. `npm audit --audit-level=high`, which is what CI runs, now passes. Six moderate findings remain, all from one minimatch advisory (GHSA-g3hv-75wg-m249, fixed only in 11.0.1+) reached through electron-builder, whose latest release still requires minimatch ^10. Clearing them needs an override that forces minimatch 11 onto the packaging toolchain, which is left out until it can be checked against a real installer build. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
There was a problem hiding this comment.
This PR performs a package-lock.json-only lockfile refresh via npm audit fix --package-lock-only, bumping several packages within their already-declared package.json version ranges to clear high-severity advisories.
Assessment: The changes are straightforward and accurate. All version bumps are minor or patch releases (vite 7.3.6→7.3.8, zod 4.6.2→4.6.7, undici 7.30.0→7.30.2, electron 43.7.9→43.8.7, electron-builder and related packages 26.17→26.18.1, hono, follow-redirects, qs, semver, and others). No logic errors, incorrect resolutions, or new security issues were introduced.
Known limitation (acknowledged in PR description): Six moderate findings remain from a single minimatch advisory (GHSA-g3hv-75wg-m249) in the app-builder-lib/@electron/universal packaging toolchain. The fix requires minimatch >=11.0.1, but electron-builder 26.18.1 still pins minimatch ^10.2.5 — meaning npm audit fix --force would downgrade electron-builder. This is an upstream constraint that cannot be resolved in this PR without breaking the build toolchain.
No blocking issues found. The PR achieves its stated goal of clearing all high-severity findings.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.



Summary
npm audit fixlimited to the version ranges already inpackage.json, lockfile only. Every bump is a patch or minor release:This clears every high finding, so the Verify job's
npm audit --audit-level=highstep passes again. That step has failed onmainsince 2 November.Still open: one moderate advisory
Six moderate findings remain, all from one
minimatchadvisory (GHSA-g3hv-75wg-m249) that only affects the packaging tools:app-builder-liband@electron/universal, both part of electron-builder.minimatch ^10.2.5, andnpm audit fix --forcewould downgrade electron-builder to 25.1.0.moderate, so it will still fail until this is handled. The options are anoverridesentry forcing minimatch 11 onto the packaging toolchain, verified with a realpackage:win/package:linuxbuild, or waiting for electron-builder to update.Testing
npm audit --audit-level=highpasses against the new lockfile.--package-lock-onlybecause a running Electron instance had the localnode_moduleslocked. This PR's CI run is the first clean install and full typecheck, test and build against it.🤖 Generated with Claude Code