uphold 1.14.0: a command seam that reads what will really run, and an unknown that is no longer a pass - #132
Merged
Merged
Conversation
… unknown that is no longer a pass Point the documented pins at 1.14.0 and bump the crate version. Minor, not patch. This release carries names a policy written against 1.13.0 cannot use: the bundled set mismatched-author; api:* as a matchable verb on the gh and glab shim tables, so a forge call that carries a body is read the way gh pr create is; unresolved on a [[shim]] table, whose default refuses before exec where a scope could not be evaluated; and refuse_unknown, foreign_hosts and redact_matches on the private-name family. It also closes four seams that reported a pass they had not established. The MCP hook seam consulted no prose rule, so every prose_regexp was dark exactly where an agent publishes. Five command lines walked past the shim, four of them ending in exit 0 with nothing printed. A blob no charset decodes was read as clean rather than refused. A forge host nobody could ask about produced no finding, no report and no exit code. Landed in this release: #116, #117, #123, #124, #126, #129, #131. A policy written against 1.13.0 loads unchanged, and every new name has to be named or inherited to run. Two things do change for a consumer who only bumps a rev or a ref: the seam fixes above start refusing text and command lines that used to pass unexamined, and the four published Go ids are triggered by the module rather than by the file that changed, at all four stages rather than at pre-commit alone. Claude-Session: https://claude.ai/code/session_01HEudouCNhFHK6UPEWcWqXd
|
Warning Review limit reachedNext included review available in 23 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 93.43% 93.43%
=======================================
Files 38 38
Lines 14414 14414
=======================================
Hits 13467 13467
Misses 947 947 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point the documented pins at 1.14.0 and bump the crate version.
Minor, not patch. This release carries names a policy written against 1.13.0
cannot use: the bundled set mismatched-author; api:* as a matchable verb on
the gh and glab shim tables, so a forge call that carries a body is read the
way gh pr create is; unresolved on a [[shim]] table, whose default refuses
before exec where a scope could not be evaluated; and refuse_unknown,
foreign_hosts and redact_matches on the private-name family.
It also closes four seams that reported a pass they had not established. The
MCP hook seam consulted no prose rule, so every prose_regexp was dark exactly
where an agent publishes. Five command lines walked past the shim, four of
them ending in exit 0 with nothing printed. A blob no charset decodes was read
as clean rather than refused. A forge host nobody could ask about produced no
finding, no report and no exit code.
Landed in this release: #116, #117, #123, #124, #126, #129, #131.
A policy written against 1.13.0 loads unchanged, and every new name has to be
named or inherited to run. Two things do change for a consumer who only bumps
a rev or a ref: the seam fixes above start refusing text and command lines
that used to pass unexamined, and the four published Go ids are triggered by
the module rather than by the file that changed, at all four stages rather
than at pre-commit alone.
https://claude.ai/code/session_01HEudouCNhFHK6UPEWcWqXd