[Enhancement] 原理图管理优化 - #6094
Open
ToobLac wants to merge 117 commits into
Open
Conversation
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java
Glavo
reviewed
Jul 16, 2026
Glavo
left a comment
Glavo
left a comment
Member
There was a problem hiding this comment.
本审查建议由 GPT-5.6 Sol 生成
已将具体审查建议标注在对应代码行。
|
试了一下 发现有关 #4518 的问题: 为什么不在没安装 |
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/nbt/NBTFileType.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/SchematicsPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/versions/ModListPage.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java # HMCLCore/src/main/java/org/jackhuang/hmcl/game/DefaultGameRepository.java
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/construct/MDListCell.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java # HMCL/src/main/resources/assets/lang/I18N_uk.properties
# Conflicts: # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/ModListPage.java # HMCL/src/main/java/org/jackhuang/hmcl/ui/instances/SchematicsPage.java # HMCLCore/src/main/java/org/jackhuang/hmcl/addon/mod/ModManager.java # HMCLCore/src/main/java/org/jackhuang/hmcl/game/DefaultGameRepository.java
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| import javafx.beans.property.ObjectProperty; | ||
| import javafx.beans.property.ReadOnlyObjectProperty; | ||
| import javafx.beans.property.SimpleObjectProperty; | ||
| import org.jackhuang.hmcl.schematic.LitematicaConfig; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck]
Unused import - org.jackhuang.hmcl.schematic.LitematicaConfig.
| import org.jackhuang.hmcl.schematic.LitematicaConfig; | ||
| import org.jackhuang.hmcl.task.Task; | ||
| import org.jackhuang.hmcl.util.Lang; | ||
| import org.jackhuang.hmcl.util.StringUtils; |
There was a problem hiding this comment.
[ERROR] [com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck]
Unused import - org.jackhuang.hmcl.util.StringUtils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4052 Resolves #4518 Resolves #3957
#3597 应在本 PR 合并后并实现 NBT 修改功能后关闭