Skip to content

Prepare tests for fakegcsserver 1.56 #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prepare tests for fakegcsserver 1.56 #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion custom-targets/git-ops/git-deployer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG GCLOUD_VERSION=456.0.0
ARG GCLOUD_VERSION=588.0.0
ARG GO_VERSION=1.24

FROM golang:${GO_VERSION} AS go-build
Expand Down
2 changes: 1 addition & 1 deletion custom-targets/helm/helm-deployer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

ARG GCLOUD_VERSION=456.0.0
ARG GCLOUD_VERSION=588.0.0
ARG GO_VERSION=1.24
ARG HELM_VERSION=3.13.2

Expand Down
3 changes: 2 additions & 1 deletion custom-targets/terraform/terraform-deployer/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// render provides rendering logic for Terraform configurations in Cloud Deploy.
package main

import (
Expand All @@ -31,7 +32,7 @@ import (
"github.com/hashicorp/hcl/v2/hclsyntax"
"github.com/hashicorp/hcl/v2/hclwrite"
"github.com/mholt/archiver/v3"
"google3/third_party/golang/github_com/zclconf/go_cty/v/v1/cty/cty"
"github.com/zclconf/go-cty/cty"
)

const (
Expand Down
3 changes: 1 addition & 2 deletions packages/gcs/gcs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ func TestUploadGCS(t *testing.T) {
fakeContent := "hello world"
fakeObj := "obj"
fakeGCS := fakestorage.NewServer([]fakestorage.Object{})
t.Cleanup(fakeGCS.Stop)
fakeGCS.CreateBucketWithOpts(fakestorage.CreateBucketOpts{Name: bucket})

fakeContentForFile := "hellooo"
Expand Down Expand Up @@ -195,8 +196,6 @@ func TestUploadGCS(t *testing.T) {
if string(o.Content) != test.wantContent {
t.Errorf("uploadGCS failed with wrong content: got %q, want %q", o.Content, test.wantContent)
}

fakeGCS.Stop()
})
}

Expand Down
2 changes: 1 addition & 1 deletion postdeploy-hooks/k8s-cleanup/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
ARG GCLOUD_VERSION=506.0.0
ARG GCLOUD_VERSION=588.0.0
ARG GO_VERSION=1.24

FROM golang:${GO_VERSION} AS build
Expand Down
Loading