[CHA-4634] feat: add getChannel API - #262
Open
mogita wants to merge 1 commit into
Open
Conversation
Adds Channel.getChannel(type, id), which calls GET /channels/{type}/{id}.
Unlike getOrCreate it never creates the channel: a missing channel returns
404, so the request also works as an existence check.
The endpoint reads its options from a JSON `payload` query parameter and
returns 400 without one, so the request data is sent there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Channel.getChannel(type, id)forGET /channels/{type}/{id}. Bumble needs a read-only channel fetch on this SDK and is not moving to the generated SDK yet.Unlike
getOrCreatethe call never creates the channel. A missing channel returns 404, so it also works as an existence check. Options arestate,messagesLimit,membersLimitandwatchersLimit.The endpoint reads its options from a JSON
payloadquery parameter and returns 400 without one, so the request data is sent there instead of as flat query parameters. Same approach asqueryMembers.Verify:
ChannelTest.whenGettingExistingChannel_thenReturnsChannelandwhenGettingMissingChannel_thenNotFoundhit the live API.GetChannelTestasserts the request shape without network access.Linear: https://linear.app/stream/issue/CHA-4634/add-getchannel-api-to-the-old-java-sdk